[4.3] Fix check create article menu item with specific category

[heelc29]

Pull Request for Issue #17708 .

Summary of Changes

• fix check introduced with Create Article menu item: displays error if Category is not selected when Default Category is set #25798
• during upmerge with [4.0] 3.9.12 Merge into J4 #27056 by @wilsonge this check is broken

as we have a onContentBeforeSave in J4 to deal with workflows. Nothing should have changed - it should be cosmetic - but just to document the change in case.

checkMenuItemBeforeSave is called when context is com_menus.item

joomla-cms/plugins/content/joomla/joomla.php

Lines 66 to 70 in c3593e9

	public function onContentBeforeSave($context, $table, $isNew, $data)
	{
	if ($context === 'com_menus.item') {
	return $this->checkMenuItemBeforeSave($context, $table, $isNew, $data);
	}

checkMenuItemBeforeSave always return true when context is com_menus.item

joomla-cms/plugins/content/joomla/joomla.php

Lines 594 to 599 in c3593e9

	private function checkMenuItemBeforeSave($context, $table, $isNew, $data)
	{
	// Check we are handling the frontend edit form.
	if ($context === 'com_menus.item') {
	return true;
	}

Testing Instructions

• add a new menu item Create Article
• enable Specific Category under Options
• do not select a category

Actual result BEFORE applying this Pull Request

menu item is saved

Expected result AFTER applying this Pull Request

menu item is not saved and an error message is displayed

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[ChristineWk]

I have tested this item ✅ successfully on 0df72f0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.}

[viocassel]

I have tested this item ✅ successfully on 0df72f0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.}

[obuisard]

Thank you @heelc29 for this PR!