[4.3] Guided Tours search by note#40607
Merged
obuisard merged 5 commits intojoomla:4.3-devfrom Jun 19, 2023
Merged
Conversation
All components that have a note field allow you to search by the value of the note. This was missed in com_guidedtours
Contributor
|
Please add note to filter search description.
|
richard67
added
Updates Requested
Contributor
|
I have tested this item ✅ successfully on 17bf4bf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40607. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 17bf4bf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40607. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40607. |
Contributor
|
Thank you Brian @brianteeman for the missing note search |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Aug 20, 2023
Новое в Joomla 4.3.3 Stable * joomla/joomla-cms#40637 + * joomla/joomla-cms#40698 - (исправлено ранее) * joomla/joomla-cms#40716 - (только для en-GB) * joomla/joomla-cms#40732 + * joomla/joomla-cms#40607 + Новое в Joomla 4.3.4 Stable * joomla/joomla-cms#40449 + * joomla/joomla-cms#40119 + * joomla/joomla-cms#40297 + * "Вход на сайт", но "Выход из системы" - разброс формулировок исправлен на термин "система", подразумевая именно вход/авторизацию пользователя, а не просто серфинг страницы сайта без авторизации * Другие мелкие исправления
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
All components that have a note field allow you to search by the value of the note. This was missed in com_guidedtours
Testing Instructions
Add a string into the note field for a tour
Search for that string in the list view
Repeat for steps
Actual result BEFORE applying this Pull Request
No matching results
Expected result AFTER applying this Pull Request
Matching results
This is not a new feature. It is a bug that it was not implemented
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed