Skip to content

Fix for TypeError: count() in webservices when running PHP 8.x #40610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obuisard merged 8 commits into from
Jul 20, 2023
Merged

Fix for TypeError: count() in webservices when running PHP 8.x #40610

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df09366
Fix for TypeError: count() when running PHP 8.x
MacJoom May 16, 2023
7c3f3ef
Merge branch '4.3-dev' into WebservicesGroupIssue
MacJoom May 16, 2023
6f4ab1f
Simplify code
MacJoom May 16, 2023
0110c19
Merge branch 'WebservicesGroupIssue' of github.com:MacJoom/joomla-cms…
MacJoom May 16, 2023
01a8308
Code cleanup
MacJoom May 22, 2023
34711cd
Update administrator/components/com_fields/src/Model/GroupModel.php
wilsonge May 23, 2023
71a798a
Merge branch 'joomla:4.3-dev' into WebservicesGroupIssue
MacJoom Jun 20, 2023
f1fdeaf
Merge branch '4.3-dev' into WebservicesGroupIssue
obuisard Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions administrator/components/com_fields/src/Model/GroupModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,29 +240,30 @@ protected function preprocessForm(Form $form, $data, $group = 'content')

$parts = FieldsHelper::extract($this->state->get('filter.context'));

// If we don't have a valid context then return early
if (!$parts) {
return;
}

// Extract the component name
$component = $parts[0];

// Extract the optional section name
$section = (count($parts) > 1) ? $parts[1] : null;
// Extract the section name
$section = $parts[1];

if ($parts) {
// Set the access control rules field component value.
$form->setFieldAttribute('rules', 'component', $component);
}
// Set the access control rules field component value.
$form->setFieldAttribute('rules', 'component', $component);

if ($section !== null) {
// Looking first in the component models/forms folder
$path = Path::clean(JPATH_ADMINISTRATOR . '/components/' . $component . '/models/forms/fieldgroup/' . $section . '.xml');
// Looking first in the component models/forms folder
$path = Path::clean(JPATH_ADMINISTRATOR . '/components/' . $component . '/models/forms/fieldgroup/' . $section . '.xml');

if (file_exists($path)) {
$lang = Factory::getLanguage();
$lang->load($component, JPATH_BASE);
$lang->load($component, JPATH_BASE . '/components/' . $component);
if (file_exists($path)) {
$lang = Factory::getLanguage();
$lang->load($component, JPATH_BASE);
$lang->load($component, JPATH_BASE . '/components/' . $component);

if (!$form->loadFile($path, false)) {
throw new \Exception(Text::_('JERROR_LOADFILE_FAILED'));
}
if (!$form->loadFile($path, false)) {
throw new \Exception(Text::_('JERROR_LOADFILE_FAILED'));
}
}
}
Expand Down