Fix for TypeError: count() in webservices when running PHP 8.x

[MacJoom]

The error occurs when doing webservices API POST call to /fields/groups/contacts/contact or /fields/groups/content/articles

Pull Request for Issue # .

Summary of Changes

Is_array test before doing count() - not needed FieldsHelper::extract returns null if there are not two parts

Testing Instructions

Code review -

or do test the webservices test with Postman and the collection from here:
https://github.com/alexandreelise/j4x-api-collection

Actual result BEFORE applying this Pull Request

TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/clients/client2/web3/web/joomla-cms/administrator/components/com_fields/src/Model/GroupModel.php:247 etc.

Expected result AFTER applying this Pull Request

No Error, Item is added

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• [x ] No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• [x ] No documentation changes for manual.joomla.org needed

[wilsonge]

Something looks wrong here. We call count within that function (unless we return null from the early bail

joomla-cms/administrator/components/com_fields/src/Helper/FieldsHelper.php

Line 65 in 7c3f3ef

if (count($parts) < 2) {

)

But in that case we should be checking for parts being null. because getting the 0th element on the line 244 of null also makes no sense

[MacJoom]

Yes OK - then we do not need to do a count again. I was just focusing on the part throwing the error... - and the section is not optional but mandatory

[alikon]

i've got a different error with postman without your PR

PHP Warning: Trying to access array offset on value of type null in /joomla-cms/administrator/components/com_fields/src/Model/GroupModel.php on line 244

[alikon]

btw applying the pr no more error

[alikon]

tested fields/groups/contacts/contact too

[alikon]

I have tested this item ✅ successfully on 0110c19

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40610.}

[richard67]

@wilsonge Could you check and if ok add an approval with the review button so GitHub doesn’t show the unresolved review anymore? As far as I can see @MacJoom has solved your concerns.

[laoneo]

The change looks ok, but I'm wondering why the context there is null?

[obuisard]

Thank you Martin @MacJoom for the PR!