Skip to content

[4.3] Guided Tours use global language keys#40319

Merged
obuisard merged 3 commits intojoomla:4.3-devfrom
heelc29:4.3/com_guidedtours/lang-global
Apr 4, 2023
Merged

[4.3] Guided Tours use global language keys#40319
obuisard merged 3 commits intojoomla:4.3-devfrom
heelc29:4.3/com_guidedtours/lang-global

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 3, 2023

Summary of Changes

use the global strings for "Status" and "ID" in heading of tours/steps lists (they are already used in edit form and for sorting)
@obuisard Should the language keys deprecated or removed?

Note: Title and Description is also inconsistent

Testing Instructions

check the used language key

Actual result BEFORE applying this Pull Request

Tour

image
image

Step

image
image

Expected result AFTER applying this Pull Request

Tour

image
image

Step

image
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 3, 2023
@obuisard
Copy link
Contributor

obuisard commented Apr 3, 2023

I believe the language keys should be deprecated.

@brianteeman
Copy link
Contributor

Surely there is no need to deprecate these strings and they can just be deleted as the code has not been released

@alikon
Copy link
Contributor

alikon commented Apr 3, 2023

yes please let's do things simply., delete without deprecations there's no need to over-engineer in this case, imho

@heelc29
Copy link
Contributor Author

heelc29 commented Apr 3, 2023

@brianteeman @alikon deleted

@alikon
Copy link
Contributor

alikon commented Apr 3, 2023

I have tested this item ✅ successfully on e3a75e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on e3a75e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.

@alikon
Copy link
Contributor

alikon commented Apr 4, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Apr 4, 2023
@obuisard obuisard merged commit fba6bb0 into joomla:4.3-dev Apr 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 4, 2023
@obuisard
Copy link
Contributor

obuisard commented Apr 4, 2023

Thank you @heelc29. Better deal with this now than later.

@heelc29 heelc29 deleted the 4.3/com_guidedtours/lang-global branch April 4, 2023 15:32
heelc29 added a commit to heelc29/joomla that referenced this pull request Apr 4, 2023
zero-24 added a commit to joomlagerman/joomla that referenced this pull request Apr 17, 2023
* add strings

joomla/joomla-cms#39902

* add copyright J!German

* translation

* translation

* fix

* translation

* update strings

joomla/joomla-cms#40197

* update strings

joomla/joomla-cms#40308

* remove strings

joomla/joomla-cms#40319

* update/remove strings

joomla/joomla-cms#40301

* update strings

joomla/joomla-cms#40318

* translation

* fix

* wording test

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* translation

* sounds better

* translate guided tour tour

* translate COM_GUIDEDTOURS_TOUR_USERS

* translate COM_GUIDEDTOURS_TOUR_MENUS

* translate COM_GUIDEDTOURS_TOUR_CATEGORIES

* translate COM_GUIDEDTOURS_TOUR_TAGS

* translate COM_GUIDEDTOURS_TOUR_BANNERS

* translate COM_GUIDEDTOURS_TOUR_CONTACTS

* translate COM_GUIDEDTOURS_TOUR_NEWSFEEDS

* translate COM_GUIDEDTOURS_TOUR_SMARTSEARCH

* translate COM_GUIDEDTOURS_TOUR_GUIDEDTOURSTEPS_STEP

* wording

Schaltfläche ist dort zu lang und besser in der Description (meist) aufgehoben

* fix #2781

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* spelling mistakes

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

* Update administrator/language/de-DE/com_guidedtours.sys.ini

* spelling

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_guidedtours.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

---------

Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants