[4.3][Guided Tours] Make filter search tooltip consistent#40197
Merged
sdwjoomla merged 3 commits intojoomla:4.3-devfrom Apr 1, 2023
Merged
[4.3][Guided Tours] Make filter search tooltip consistent#40197sdwjoomla merged 3 commits intojoomla:4.3-devfrom
sdwjoomla merged 3 commits intojoomla:4.3-devfrom
Conversation
Contributor
|
The PR is correct for consistency but if you check you will see that there is no code for searching the descrption |
Contributor
Author
|
Please see this merged PR #40118 to see code for description search. |
Contributor
|
The query still fails with that merged pr
|
Contributor
|
I have tested this item ✅ successfully on 498f435 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
Contributor
Author
|
The language constants and not values are stored in the tables, thus, no match found.
|
Contributor
|
no thats not it. the query is supposed to take account of that (and it works for the title) |
Quy
changed the title
Contributor
|
I have tested this item ✅ successfully on 498f435 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197. |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Apr 2, 2023
zero-24
added a commit
to joomlagerman/joomla
that referenced
this pull request
Apr 17, 2023
* add strings joomla/joomla-cms#39902 * add copyright J!German * translation * translation * fix * translation * update strings joomla/joomla-cms#40197 * update strings joomla/joomla-cms#40308 * remove strings joomla/joomla-cms#40319 * update/remove strings joomla/joomla-cms#40301 * update strings joomla/joomla-cms#40318 * translation * fix * wording test * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * translation * sounds better * translate guided tour tour * translate COM_GUIDEDTOURS_TOUR_USERS * translate COM_GUIDEDTOURS_TOUR_MENUS * translate COM_GUIDEDTOURS_TOUR_CATEGORIES * translate COM_GUIDEDTOURS_TOUR_TAGS * translate COM_GUIDEDTOURS_TOUR_BANNERS * translate COM_GUIDEDTOURS_TOUR_CONTACTS * translate COM_GUIDEDTOURS_TOUR_NEWSFEEDS * translate COM_GUIDEDTOURS_TOUR_SMARTSEARCH * translate COM_GUIDEDTOURS_TOUR_GUIDEDTOURSTEPS_STEP * wording Schaltfläche ist dort zu lang und besser in der Description (meist) aufgehoben * fix #2781 * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * spelling mistakes * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini * Update administrator/language/de-DE/com_guidedtours.sys.ini * spelling * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> * Update administrator/language/de-DE/com_guidedtours.sys.ini Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com> --------- Co-authored-by: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Make filter search tooltip consistent with other tooltips.
Testing Instructions
Code review.