Skip to content

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 3, 2023

Summary of Changes

As directly access the input variable is deprecated since Joomla 4.0 in #28313, the core should not use it anymore. This pr changes the call to the getInput function.

Missed by PR #39029

Testing Instructions

Open backend

Actual result BEFORE applying this Pull Request

Use of deprecated access to the application's input property

Expected result AFTER applying this Pull Request

All works like before, but without using deprecated access to the application's input property

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@heelc29 heelc29 force-pushed the 4.4/application-input branch from 2fea32f to f73e937 Compare April 3, 2023 14:27
@MacJoom MacJoom self-assigned this Apr 3, 2023
@alikon
Copy link
Contributor

alikon commented Apr 4, 2023

I have tested this item ✅ successfully on 7ba9127


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40313.

@richard67
Copy link
Member

@heelc29
Copy link
Contributor Author

heelc29 commented Apr 4, 2023

@richard67 Check out #40305

@richard67
Copy link
Member

I have tested this item ✅ successfully on 4ee9f72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40313.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40313.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2023
@MacJoom MacJoom merged commit 784a69f into joomla:4.4-dev Apr 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 4, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.0 milestone Apr 4, 2023
@MacJoom
Copy link
Contributor

MacJoom commented Apr 4, 2023

Thank you!

@heelc29 heelc29 deleted the 4.4/application-input branch August 21, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants