[4.3] Change application input access to getInput #39029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
requested changes
Oct 22, 2022
administrator/components/com_config/src/Model/ApplicationModel.php
Outdated
Show resolved
Hide resolved
administrator/components/com_content/src/Model/ArticlesModel.php
Outdated
Show resolved
Hide resolved
HLeithner
requested changes
Oct 23, 2022
administrator/components/com_associations/src/Model/AssociationsModel.php
Show resolved
Hide resolved
Co-authored-by: Harald Leithner <[email protected]>
Member
|
Thanks, there is still room for improvements but it's more important to now use deprecated functions for now. |
This was referenced Jan 15, 2023
This was referenced Apr 2, 2023
This was referenced Jul 23, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As directly access the input variable is deprecated since Joomla 4.0 in #28313, the core should not use it anymore. This pr changes the call to the
getInputfunction.Testing Instructions
Open the back or front end.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed