Merged
Conversation
This was referenced Mar 31, 2023
Contributor
|
I have tested this item ✅ successfully on 3bd1730 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 3bd1730 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40270. |
Contributor
|
Thank you Dimitris @dgrammatiko. Yes, this needed to be in. Thank you very much for the PR. |
Denitz
pushed a commit
to Denitz/joomla-cms
that referenced
this pull request
Apr 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40268 .
Summary of Changes
Testing Instructions
Navigate anywhere in the backend where the toolbar has a help button and click on it
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
The help popup should return a 404 page (this is a different problem)
Link to documentations
Please select:
@obuisard I guess this is a release blocker