[4.3][csp] Remove inline onclick from the Help button#39727
Merged
obuisard merged 4 commits intojoomla:4.3-devfrom Jan 29, 2023
Merged
[4.3][csp] Remove inline onclick from the Help button#39727obuisard merged 4 commits intojoomla:4.3-devfrom
obuisard merged 4 commits intojoomla:4.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on e1e6e6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on e1e6e6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727. |
Contributor
|
Thank you Dimitris @dgrammatiko ! |
Contributor
|
@dgrammatiko @viocassel @Quy Without this PR the url is correct (but not working at the moment for J4.3) |
Contributor
|
The 404 is because @obuisard hasnt set uip the proxy |
Contributor
Author
Contributor
|
We are working with the documentation team to resolve the missing docs for 4.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Pull Request for Issue # .
Summary of Changes
Joomla.popupWindowTesting Instructions
This pr needs
npm ciCheck any page on the backend with a help button that when clicking on it the help window opens as expected
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Where do we register the deprecations?