Skip to content

[4.3][csp] Remove inline onclick from the Help button#39727

Merged
obuisard merged 4 commits intojoomla:4.3-devfrom
dgrammatiko:4.3-dev-csp-toolbar
Jan 29, 2023
Merged

[4.3][csp] Remove inline onclick from the Help button#39727
obuisard merged 4 commits intojoomla:4.3-devfrom
dgrammatiko:4.3-dev-csp-toolbar

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Deprecate Joomla.popupWindow
  • Use data attributes to pass the data from PHP to JS
  • Add the required onclick functionality based on the data attributes

Testing Instructions

This pr needs npm ci

Check any page on the backend with a help button that when clicking on it the help window opens as expected

Actual result BEFORE applying this Pull Request

Screenshot 2023-01-27 at 15 15 46

Expected result AFTER applying this Pull Request

Screenshot 2023-01-27 at 15 14 43

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Where do we register the deprecations?

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Jan 27, 2023
@Quy
Copy link
Contributor

Quy commented Jan 27, 2023

I have tested this item ✅ successfully on e1e6e6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e1e6e6e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.

@Quy
Copy link
Contributor

Quy commented Jan 29, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39727.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 29, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 29, 2023
@obuisard obuisard merged commit dc77d47 into joomla:4.3-dev Jan 29, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 29, 2023
@obuisard
Copy link
Contributor

Thank you Dimitris @dgrammatiko !

@dgrammatiko dgrammatiko deleted the 4.3-dev-csp-toolbar branch January 29, 2023 19:59
@heelc29
Copy link
Contributor

heelc29 commented Mar 29, 2023

@dgrammatiko @viocassel @Quy
Are you sure this is working? If I click the help button then it will open this url (notice the escaped slashes)
image
the Microsoft Edge (Version 111.0.1661.54) the second one is replaced to two slashes
image
and I will be redirected to the Main Page
image

Without this PR the url is correct (but not working at the moment for J4.3)
image

@brianteeman
Copy link
Contributor

The 404 is because @obuisard hasnt set uip the proxy

@dgrammatiko
Copy link
Contributor Author

@heelc29 check #40270

@obuisard
Copy link
Contributor

We are working with the documentation team to resolve the missing docs for 4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants