Skip to content

Fix compatibility break in validation.js #40230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
obuisard merged 2 commits into from
Mar 30, 2023
Merged

Fix compatibility break in validation.js #40230

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
819f565
Fix validator compatibility break
Fedik Mar 29, 2023
6ce2963
Merge branch '4.3-dev' into validator-bc-fix
QuyTon Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions build/media_source/system/js/fields/validate.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,15 @@ class JFormValidator {
let valid = true;
let message;
let error;
let fields;
const invalid = [];

// Validate form fields
const fields = [].slice.call(form.elements);
if (form.nodeName === 'FORM') {
fields = [].slice.call(form.elements);
} else {
fields = [].slice.call(form.querySelectorAll('input, textarea, select, button, fieldset'));
}
fields.forEach((field) => {
if (this.validate(field) === false) {
valid = false;
Expand Down Expand Up @@ -284,7 +289,13 @@ class JFormValidator {

attachToForm(form) {
const inputFields = [];
const elements = [].slice.call(form.elements);
let elements;

if (form.nodeName === 'FORM') {
elements = [].slice.call(form.elements);
} else {
elements = [].slice.call(form.querySelectorAll('input, textarea, select, button, fieldset'));
}

// Iterate through the form object and attach the validate method to all input fields.
elements.forEach((element) => {
Expand Down