Skip to content

Fix compatibility break in validation.js#40230

Merged
obuisard merged 2 commits intojoomla:4.3-devfrom
Fedik:validator-bc-fix
Mar 30, 2023
Merged

Fix compatibility break in validation.js#40230
obuisard merged 2 commits intojoomla:4.3-devfrom
Fedik:validator-bc-fix

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Mar 29, 2023

Summary of Changes

As result of #39350 it become impossible to use validation over non <form> element.
Hovewer some extensions use this feature to validate form "per section".

Testing Instructions

Apply patch. Run npm install
Open a form for "New article".
In Browser console, run 2 commands (one by one):

document.formvalidator.isValid(window['item-form']);

document.formvalidator.isValid(window['item-form'].parentElement);

Actual result BEFORE applying this Pull Request

First command executed, and you get a validation message.
Second command throws an error

Expected result AFTER applying this Pull Request

Both commands works, and shows validation message

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 819f565


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 819f565


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.

@Quy Quy removed Release Blocker NPM Resource Changed This Pull Request can't be tested by Patchtester labels Mar 30, 2023
@Quy
Copy link
Contributor

Quy commented Mar 30, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 30, 2023
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Mar 30, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 30, 2023
@obuisard obuisard merged commit b285fa6 into joomla:4.3-dev Mar 30, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 30, 2023
@obuisard
Copy link
Contributor

Thank you Fedir @Fedik for the fix

@Fedik Fedik deleted the validator-bc-fix branch March 30, 2023 19:22
Denitz pushed a commit to Denitz/joomla-cms that referenced this pull request Apr 1, 2023
@compojoom
Copy link
Contributor

thanks for the fix @Fedik ! Will there be a 4.2.10 release with this fix?

@obuisard
Copy link
Contributor

obuisard commented Apr 2, 2023

thanks for the fix @Fedik ! Will there be a 4.2.10 release with this fix?

No, you will have to wait for 4.3, coming April, 18 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants