Fix compatibility break in validation.js#40230
Merged
obuisard merged 2 commits intojoomla:4.3-devfrom Mar 30, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 819f565 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230. |
Contributor
|
I have tested this item ✅ successfully on 819f565 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40230. |
Contributor
|
Thank you Fedir @Fedik for the fix |
Denitz
pushed a commit
to Denitz/joomla-cms
that referenced
this pull request
Apr 1, 2023
Contributor
|
thanks for the fix @Fedik ! Will there be a 4.2.10 release with this fix? |
Contributor
No, you will have to wait for 4.3, coming April, 18 :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As result of #39350 it become impossible to use validation over non
<form>element.Hovewer some extensions use this feature to validate form "per section".
Testing Instructions
Apply patch. Run
npm installOpen a form for "New article".
In Browser console, run 2 commands (one by one):
Actual result BEFORE applying this Pull Request
First command executed, and you get a validation message.
Second command throws an error
Expected result AFTER applying this Pull Request
Both commands works, and shows validation message
Link to documentations
Please select: