Update Table.php

[Kurantje]

Query requires back-quoted table name to acommodate for table names with special characters.

Pull Request for Issue #39487

Summary of Changes

On line 734 it states: ->from($this->_tbl);
This should be: ->from($this->_db->quoteName($this->_tbl));

Testing Instructions

Create a component using a table with a special character, e.g. da-events
Go to ...?option=&view=event&layout=edit&id=1 to get the first element from the table

Actual result BEFORE applying this Pull Request

Invalid mySQL query exception

Expected result AFTER applying this Pull Request

In edit.php get the data from the da-events table for id=1

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ReLater]

I have tested this item 🔴 unsuccessfully on 158adff

See my comment below

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.}

[ReLater]

There are some more code places that must be fixed via quoteName().

At least methods checkOut(), checkIn(). but I didn't test any further. Just opened and closed an item in my test component where I renamed the main table from ghsthing to ghsvs-thing and added protected $_tbl = '#__ghsvs-thing'; in my table class (extends Table). I got errors like example:

1064 You have an error in your SQL syntax; 
check the manual that corresponds to your MariaDB server version 
for the right syntax to use near '-thing SET `checked_out` = 340 ,
 `checked_out_time` = '2022-12-24 19:22:39' ...' at line 1

I didn't save or update and so on then.

The first fix of this pr ( load() ) works, but ... see above.

[ReLater]

@Kurantje
I have provided a pr in your branch that you can merge into your branch and into this pr at the same time if you like to.
See https://github.com/Kurantje/joomla-cms/pull/1

[Kurantje]

@ReLater, Thanks for highlighting. Submitted Table.php again, now with all sql table references with QuoteName

[ReLater]

@Kurantje
Why did you close your PR?

[Kurantje]

Oops! Didn't mean to. Will reopen. Thanks!

[ReLater]

I have tested this item ✅ successfully on 4e50a2d

• PHP 8.1.13
• MySQLi 10.5.18-MariaDB-1:10.5.18+maria~ubu2004-log
• Joomla 4.3.0-alpha2-dev
• Joomla_4.2.7-dev

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.}

[joomdonation]

I have tested this item ✅ successfully on 4e50a2d

Code review + tried to view, delete, publish, unpublish.... records and all still works.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.}

[joomdonation]

RTC. Thanks !

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39489.}

[roland-d]

Thank you