Update Table.php (#39489)

* Update Table.php

Query requires back-quoted table name to acommodate for table names with special characters.

* quoteName in methods checkIn(), checkOut()

See #39489 (comment)

* quoteName in all mysql table references

Legal table names with special characters throw exceptions. QuoteName each query avoids fixes this

Co-authored-by: ReLater <[email protected]>

Author: Kurantje

libraries/src/Table/Table.php

@@ -731,7 +731,7 @@ public function load($keys = null, $reset = true)
         // Initialise the query.
         $query = $this->_db->getQuery(true)
             ->select('*')
-            ->from($this->_tbl);
+            ->from($this->_db->quoteName($this->_tbl));
         $fields = array_keys($this->getProperties());
 
         foreach ($keys as $field => $value) {
@@ -1038,7 +1038,7 @@ public function delete($pk = null)
 
         // Delete the row by primary key.
         $query = $this->_db->getQuery(true)
-            ->delete($this->_tbl);
+            ->delete($this->_db->quoteName($this->_tbl));
         $this->appendPrimaryKeys($query, $pk);
 
         $this->_db->setQuery($query);
@@ -1119,7 +1119,7 @@ public function checkOut($userId, $pk = null)
 
         // Check the row out by primary key.
         $query = $this->_db->getQuery(true)
-            ->update($this->_tbl)
+            ->update($this->_db->quoteName($this->_tbl))
             ->set($this->_db->quoteName($checkedOutField) . ' = ' . (int) $userId)
             ->set($this->_db->quoteName($checkedOutTimeField) . ' = ' . $this->_db->quote($time));
         $this->appendPrimaryKeys($query, $pk);
@@ -1200,7 +1200,7 @@ public function checkIn($pk = null)
 
         // Check the row in by primary key.
         $query = $this->_db->getQuery(true)
-            ->update($this->_tbl)
+            ->update($this->_db->quoteName($this->_tbl))
             ->set($this->_db->quoteName($checkedOutField) . ' = ' . $nullID)
             ->set($this->_db->quoteName($checkedOutTimeField) . ' = ' . $nullDate);
         $this->appendPrimaryKeys($query, $pk);
@@ -1246,7 +1246,7 @@ public function hasPrimaryKey()
         } else {
             $query = $this->_db->getQuery(true)
                 ->select('COUNT(*)')
-                ->from($this->_tbl);
+                ->from($this->_db->quoteName($this->_tbl));
             $this->appendPrimaryKeys($query);
 
             $this->_db->setQuery($query);
@@ -1312,7 +1312,7 @@ public function hit($pk = null)
 
         // Check the row in by primary key.
         $query = $this->_db->getQuery(true)
-            ->update($this->_tbl)
+            ->update($this->_db->quoteName($this->_tbl))
             ->set($this->_db->quoteName($hitsField) . ' = (' . $this->_db->quoteName($hitsField) . ' + 1)');
         $this->appendPrimaryKeys($query, $pk);
         $this->_db->setQuery($query);
@@ -1399,7 +1399,7 @@ public function getNextOrder($where = '')
         // Get the largest ordering value for a given where clause.
         $query = $this->_db->getQuery(true)
             ->select('MAX(' . $this->_db->quoteName($this->getColumnAlias('ordering')) . ')')
-            ->from($this->_tbl);
+            ->from($this->_db->quoteName($this->_tbl));
 
         if ($where) {
             $query->where($where);
@@ -1454,11 +1454,11 @@ public function reorder($where = '')
         $quotedOrderingField = $this->_db->quoteName($this->getColumnAlias('ordering'));
 
         $subquery = $this->_db->getQuery(true)
-            ->from($this->_tbl)
+            ->from($this->_db->quoteName($this->_tbl))
             ->selectRowNumber($quotedOrderingField, 'new_ordering');
 
         $query = $this->_db->getQuery(true)
-            ->update($this->_tbl)
+            ->update($this->_db->quoteName($this->_tbl))
             ->set($quotedOrderingField . ' = sq.new_ordering');
 
         $innerOn = array();
@@ -1543,7 +1543,7 @@ public function move($delta, $where = '')
 
         // Select the primary key and ordering values from the table.
         $query->select(implode(',', $this->_tbl_keys) . ', ' . $quotedOrderingField)
-            ->from($this->_tbl);
+            ->from($this->_db->quoteName($this->_tbl));
 
         // If the movement delta is negative move the row up.
         if ($delta < 0) {
@@ -1581,15 +1581,15 @@ public function move($delta, $where = '')
         if (!empty($row)) {
             // Update the ordering field for this instance to the row's ordering value.
             $query->clear()
-                ->update($this->_tbl)
+                ->update($this->_db->quoteName($this->_tbl))
                 ->set($quotedOrderingField . ' = ' . (int) $row->$orderingField);
             $this->appendPrimaryKeys($query);
             $this->_db->setQuery($query);
             $this->_db->execute();
 
             // Update the ordering field for the row to this instance's ordering value.
             $query->clear()
-                ->update($this->_tbl)
+                ->update($this->_db->quoteName($this->_tbl))
                 ->set($quotedOrderingField . ' = ' . (int) $this->$orderingField);
             $this->appendPrimaryKeys($query, $row);
             $this->_db->setQuery($query);
@@ -1600,7 +1600,7 @@ public function move($delta, $where = '')
         } else {
             // Update the ordering field for this instance.
             $query->clear()
-                ->update($this->_tbl)
+                ->update($this->_db->quoteName($this->_tbl))
                 ->set($quotedOrderingField . ' = ' . (int) $this->$orderingField);
             $this->appendPrimaryKeys($query);
             $this->_db->setQuery($query);
@@ -1689,7 +1689,7 @@ public function publish($pks = null, $state = 1, $userId = 0)
         foreach ($pks as $pk) {
             // Update the publishing state for rows with the given primary keys.
             $query = $this->_db->getQuery(true)
-                ->update($this->_tbl)
+                ->update($this->_db->quoteName($this->_tbl))
                 ->set($this->_db->quoteName($publishedField) . ' = ' . (int) $state);
 
             // If publishing, set published date/time if not previously set