Skip to content

Add inlinehelp button to FormView #39073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 2, 2023
Merged

Add inlinehelp button to FormView #39073

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d273fd3
Add inlinehelp button to FormView
HLeithner Oct 25, 2022
5cc9764
Update libraries/src/MVC/View/FormView.php
HLeithner Oct 25, 2022
ccc027e
Update libraries/src/MVC/View/FormView.php
HLeithner Oct 25, 2022
6da5116
Merge branch '4.3-dev' into feature/inlinehelp
QuyTon Jan 27, 2023
b62a9c4
Merge branch '4.3-dev' into feature/inlinehelp
QuyTon Apr 1, 2023
3832c5c
Merge branch '5.0-dev' into feature/inlinehelp
HLeithner Aug 31, 2023
f4c9ab5
Merge remote-tracking branch 'upstream/5.0-dev' into feature/inlinehelp
HLeithner Sep 2, 2023
d10e5bb
Unrelated CS fix
HLeithner Sep 2, 2023
16b0be9
Unrelated CS fix
HLeithner Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libraries/src/MVC/View/FormView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

use Joomla\CMS\Component\ComponentHelper;
use Joomla\CMS\Factory;
use Joomla\CMS\Form\Form;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Object\CMSObject;
use Joomla\CMS\Toolbar\ToolbarHelper;
Expand Down Expand Up @@ -230,6 +231,15 @@ protected function addToolbar()

ToolbarHelper::divider();

if ($this->form instanceof Form) {
$formConfig = $this->form->getXml()->config->inlinehelp;
$targetClass = (string) $formConfig['targetclass'] ?: 'hide-aware-inline-help';

if ((string) $formConfig['button'] === 'show') {
ToolbarHelper::inlinehelp($targetClass);
}
}

if ($this->helpLink) {
ToolbarHelper::help($this->helpLink);
}
Expand Down