Skip to content

Add inlinehelp button to FormView #39073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 2, 2023
Merged

Add inlinehelp button to FormView #39073

merged 9 commits into from
Sep 2, 2023

Conversation

@HLeithner
Copy link
Member

@HLeithner HLeithner commented Oct 25, 2022

Based on #37158 adding this functionallity to the FormView

Summary of Changes

Add inlinehelp button to FormView

Testing Instructions

Take a component using FormView and add the xml to the form.xml

  <config>
    <inlinehelp button="show"/>
  </config>

Watch out for the button

Actual result BEFORE applying this Pull Request

Nothing happens

Expected result AFTER applying this Pull Request

Shows the inline help button

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: TBA

  • No documentation changes for manual.joomla.org needed

heelc29
heelc29 reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cs

wilsonge
wilsonge reviewed Oct 25, 2022
View reviewed changes
@richard67 richard67 added the Maintainers Checked Used if the PR is conceptional useful label Oct 30, 2022
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 25, 2023
@Hackwar Hackwar added the Feature label Apr 7, 2023
@HLeithner HLeithner changed the base branch from 4.3-dev to 5.0-dev May 8, 2023 15:02
@HLeithner
Copy link
Member Author

HLeithner commented May 8, 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

@mckillo mckillo mentioned this pull request Jun 14, 2023
Closed
@wilsonge wilsonge enabled auto-merge (squash) August 31, 2023 21:41
@wilsonge wilsonge added this to the Joomla! 5.0 milestone Aug 31, 2023
@HLeithner HLeithner disabled auto-merge September 2, 2023 15:24
@HLeithner HLeithner merged commit 5f9970f into joomla:5.0-dev Sep 2, 2023
@HLeithner HLeithner deleted the feature/inlinehelp branch September 2, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonge wilsonge wilsonge left review comments

@richard67 richard67 richard67 approved these changes

+1 more reviewer

@heelc29 heelc29 heelc29 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Maintainers Checked Used if the PR is conceptional useful Small A PR which only has a small change

Projects

None yet

Milestone

Joomla! 5.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@HLeithner @wilsonge @richard67 @heelc29 @laoneo @Hackwar @joomla-cms-bot @QuyTon