Skip to content

Fix error#38989

Merged
rdeutz merged 4 commits intojoomla:4.2-devfrom
RickR2H:codemirror-error
Oct 23, 2022
Merged

Fix error#38989
rdeutz merged 4 commits intojoomla:4.2-devfrom
RickR2H:codemirror-error

Conversation

@RickR2H
Copy link
Member

@RickR2H RickR2H commented Oct 18, 2022

Pull Request for Issue # .
PR #38863 introduces a bug if Codemirror is selected as default editor.
Image-002

Testing Instructions

Set the default editor to Codemirror

Actual result BEFORE applying this Pull Request

When an article is edited, there is an error when Codemirror is set ad default editor.

Warning: Undefined property: stdClass::$readOnly in C:\wamp64\www\joomlacms\plugins\editors\codemirror\layouts\editors\codemirror\element.php on line 41

Expected result AFTER applying this Pull Request

The error is the article editor is gone and the changes made in #38863 still work.

@richard67
Copy link
Member

Doesn’t isset also cover the check for not null so the check for not null can be removed?

@RickR2H
Copy link
Member Author

RickR2H commented Oct 19, 2022

Doesn’t isset also cover the check for not null so the check for not null can be removed?

You are right. isset will return true if variable is set and not NULL.

@alikon
Copy link
Contributor

alikon commented Oct 21, 2022

I have tested this item ✅ successfully on c07eb44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on c07eb44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 21, 2022
@rdeutz rdeutz merged commit 124e29a into joomla:4.2-dev Oct 23, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 23, 2022
@RickR2H RickR2H deleted the codemirror-error branch October 31, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments