Fix error#38989
Merged
rdeutz merged 4 commits intojoomla:4.2-devfrom Oct 23, 2022
RickR2H:codemirror-error
Merged
Conversation
Member
|
Doesn’t isset also cover the check for not null so the check for not null can be removed? |
Member
Author
You are right. isset will return true if variable is set and not NULL. |
Contributor
|
I have tested this item ✅ successfully on c07eb44 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on c07eb44 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38989. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .

PR #38863 introduces a bug if Codemirror is selected as default editor.
Testing Instructions
Set the default editor to Codemirror
Actual result BEFORE applying this Pull Request
When an article is edited, there is an error when Codemirror is set ad default editor.
Warning: Undefined property: stdClass::$readOnly in C:\wamp64\www\joomlacms\plugins\editors\codemirror\layouts\editors\codemirror\element.php on line 41
Expected result AFTER applying this Pull Request
The error is the article editor is gone and the changes made in #38863 still work.