[4.2] codemirror full screen#38863
Merged
roland-d merged 4 commits intojoomla:4.2-devfrom Oct 7, 2022
Merged
Conversation
In com_templates if you display the original file as well as the override then you have two instances of codemirror with the original file as readonly. Both have the message "Press xx to toggle Full Screen editing" which not only doesnt make sense on a readonly instance of the editor and not surprisingly doesnt work. This PR removes the message and associated options from the codemirror layout if the editor is defined as readonly in the xml
sandewt
reviewed
Sep 29, 2022
plugins/editors/codemirror/layouts/editors/codemirror/element.php
Outdated
Show resolved
Hide resolved
Member
|
I have tested this item ✅ successfully on c944a91 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on c944a91 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38863. |
Contributor
|
Thank you |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In com_templates if you display the original file as well as the override then you have two instances of codemirror with the original file as readonly. Both have the message "Press xx to toggle Full Screen editing" which doesnt make sense on a readonly instance of the editor and not surprisingly doesnt work.
This PR removes the message and associated options from the codemirror layout if the editor is defined as readonly in the xml
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request