Skip to content

Conversation

@brianteeman
Copy link
Contributor

oops missed updating these two files to use the html entity instead of the three dots

see #38638

oops missed updating these two files to use the html entity instead of the three dots
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Sep 6, 2022
@toivo
Copy link
Contributor

toivo commented Sep 7, 2022

I have tested this item ✅ successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

2 similar comments
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

@Abernyte-Git
Copy link

I have tested this item ✅ successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

@HLeithner
Copy link
Member

as commented in the other pr can we please use the proper utf8 character and not the html encoded string.

@brianteeman
Copy link
Contributor Author

No I will not change it and we have plenty of html in our strings.

&hellip is easier to type and visually an editor will not mistakenly type ... when they mean …

As already explained we must use an ellipsis for accessibility and changing to use the utf8 … from the ... will not help as translators etc will not SEE that they are different and will continue to type ... especially as its much easier to type ... than it is to look up the utf8 character. It's certainly easier for me to type &hellip than it is to open a character map and locate the utf8 map and then locate the ellipsis and insert it into a document

@Razzo1987
Copy link
Contributor

I have tested this item ✅ successfully on 114db67


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710.

@infograf768
Copy link
Member

The problem using the web ellipsis character (UTF8 or hellip;) instead of 3 periods is the space between the dots. It entirely depends on the font used. In some cases the ellipsis is hardly readable.

Example:

Screenshot 2022-09-07 at 10 50 59

@brianteeman
Copy link
Contributor Author

using three individual dots is simply wrong

@Razzo1987
Copy link
Contributor

3 dot, utf8 or ellipsis?

How does a screen reader behave for blind users?
I don't know the answer, but I think it might help us figure out what not to use.

@brianteeman
Copy link
Contributor Author

brianteeman commented Sep 7, 2022

I don't know the answer, but I think it might help us figure out what not to use.

I already did the research ;)

Sadly there is no uniform answer for all screen readers and it also depends what mode they are in.

https://bighack.org/accessibility-screen-readers-special-characters-and-unicode-symbols/

https://tosbourn.com/the-importance-of-using-the-ellipsis-character/

https://www.deque.com/blog/dont-screen-readers-read-whats-screen-part-1-punctuation-typographic-symbols/#typo

@infograf768
Copy link
Member

infograf768 commented Sep 7, 2022

Anyhow, the patch is wrong in English as there is no obvious breaking space before the ellipsis. This lets that ellipsis to be pushed to next line if no space enough for the phrase to display in the available box.
I guess the patch should rather be  …

we get with the patch as is
Screenshot 2022-09-07 at 11 32 29

instead of what it should be:

Screenshot 2022-09-07 at 11 34 34

(In French we do not have the issue as there is no space before the ellipsis —or 3 dots as multiple dots don't break—)

@brianteeman
Copy link
Contributor Author

sorry JM the english is fine

@brianteeman
Copy link
Contributor Author

no one is forced to merge this

@N6REJ
Copy link
Contributor

N6REJ commented Sep 8, 2022

@brianteeman stop being defensive. JM brings up a valid point. it's clearly NOT fine in english

@N6REJ
Copy link
Contributor

N6REJ commented Sep 8, 2022

@chmst can the accessibility team give some feedback?

@brianteeman
Copy link
Contributor Author

@N6REJ please educate me with real world examples of the strings chanhged in this PR how it is ever wrong in english and please provide documented evidence of that

@N6REJ
Copy link
Contributor

N6REJ commented Sep 9, 2022

he's not talking about the string he's talking about the string behavior and THAT as he showed is currently wrong which was the OP point

@brianteeman
Copy link
Contributor Author

brianteeman commented Sep 9, 2022

Never mind. Ignore what I said if you want. Merge or reject - not my call

COM_MEDIA_RENAME_ERROR="Error renaming item."
COM_MEDIA_RENAME_SUCCESS="Item renamed."
COM_MEDIA_SEARCH="Search..."
COM_MEDIA_SEARCH="Search …"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the ellipsis (in the admin panel without the ellipsis), as this creates a problem.

Screenshot_1

@brianteeman brianteeman deleted the ellipsis_part2 branch September 19, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants