-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
ellipsis part 2 #38710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ellipsis part 2 #38710
Conversation
oops missed updating these two files to use the html entity instead of the three dots
|
I have tested this item ✅ successfully on 114db67 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710. |
2 similar comments
|
I have tested this item ✅ successfully on 114db67 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710. |
|
I have tested this item ✅ successfully on 114db67 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710. |
|
as commented in the other pr can we please use the proper utf8 character and not the html encoded string. |
|
No I will not change it and we have plenty of html in our strings. &hellip is easier to type and visually an editor will not mistakenly type ... when they mean … As already explained we must use an ellipsis for accessibility and changing to use the utf8 … from the ... will not help as translators etc will not SEE that they are different and will continue to type ... especially as its much easier to type ... than it is to look up the utf8 character. It's certainly easier for me to type &hellip than it is to open a character map and locate the utf8 map and then locate the ellipsis and insert it into a document |
|
I have tested this item ✅ successfully on 114db67 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38710. |
|
using three individual dots is simply wrong |
|
3 dot, utf8 or ellipsis? How does a screen reader behave for blind users? |
I already did the research ;) Sadly there is no uniform answer for all screen readers and it also depends what mode they are in. https://bighack.org/accessibility-screen-readers-special-characters-and-unicode-symbols/ https://tosbourn.com/the-importance-of-using-the-ellipsis-character/ |
|
Anyhow, the patch is wrong in English as there is no obvious breaking space before the ellipsis. This lets that ellipsis to be pushed to next line if no space enough for the phrase to display in the available box. instead of what it should be: (In French we do not have the issue as there is no space before the ellipsis —or 3 dots as multiple dots don't break—) |
|
sorry JM the english is fine |
|
no one is forced to merge this |
|
@brianteeman stop being defensive. JM brings up a valid point. it's clearly NOT fine in english |
|
@chmst can the accessibility team give some feedback? |
|
@N6REJ please educate me with real world examples of the strings chanhged in this PR how it is ever wrong in english and please provide documented evidence of that |
|
he's not talking about the string he's talking about the string behavior and THAT as he showed is currently wrong which was the OP point |
|
Never mind. Ignore what I said if you want. Merge or reject - not my call |
| COM_MEDIA_RENAME_ERROR="Error renaming item." | ||
| COM_MEDIA_RENAME_SUCCESS="Item renamed." | ||
| COM_MEDIA_SEARCH="Search..." | ||
| COM_MEDIA_SEARCH="Search …" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




oops missed updating these two files to use the html entity instead of the three dots
see #38638