Use ellipsis - part 1 #38638

brianteeman · 2022-08-30T08:20:07Z

Following the style guide and accessibility recommendations this PR changes the use of ... (dot dot dot) to the html entity for an ellipsis.

For example some screenreaders will announce the three dots eg read more dot dot dot but with an ellipsis they pause and do not say dot dot dot

This PR is only for the language strings. A further PR will follow to address truncation

PARTIAL Pull Request for Issue #38630

Following the style guide and accessibility recommendations this PR changes the use of ... (dot dot dot) to the html entity for an ellipsis. For example some screenreaders will announce the three dots eg read more dot dot dot but with an ellipsis they pause and do not say dot dot dot This PR is only for the language strings. A further PR will follow to address truncation

administrator/language/en-GB/joomla.ini

api/language/en-GB/joomla.ini

tecpromotion

Maybe this should be separated. Already hyphenated and lowercase elsewhere.

Co-authored-by: Stefan Wendhausen <[email protected]>

brianteeman · 2022-08-30T08:29:09Z

Maybe this should be separated. Already hyphenated and lowercase elsewhere.

Sorry I dont understand what you are saying - maybe I need more coffee

tecpromotion

Thanks @brianteeman

tecpromotion · 2022-08-30T19:37:42Z

I have tested this item ✅ successfully on 56ac93c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.}

N6REJ · 2022-08-30T20:05:26Z

@brianteeman docs will need to be updated as it specifically states "three periods"

brianteeman · 2022-08-30T20:11:12Z

Where? Search didn't find any. https://docs.joomla.org/index.php?title=Special:Search&profile=default&search=%22three%20periods%22&fulltext=1

Quy · 2022-08-30T21:24:59Z

I have tested this item ✅ successfully on 56ac93c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.}

Quy · 2022-08-30T21:25:19Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38638.}

N6REJ · 2022-08-31T02:15:22Z

@brianteeman https://developer.joomla.org/en-gb-user-interface-text-guidelines/punctuation.html

An ellipsis is a set of three periods ( ... ) indicating an omission. The group of periods should have a single space on either side. Unless it is at the end of a string where there is no space or period after.
Example

Read more ...
Create some text ... add some pictures.

Notice it says "three periods"

brianteeman · 2022-08-31T07:10:34Z

@N6REJ thanks - the docs have been updated just waiting for a merge

roland-d · 2022-08-31T20:34:11Z

Thank you

brianteeman · 2022-08-31T20:47:39Z

thanks

joomla/joomla-cms#38638 + joomla/joomla-cms#38622 + joomla/joomla-cms#38619 + joomla/joomla-cms#38592 + joomla/joomla-cms#38541 - (только для en-GB) joomla/joomla-cms#38537 - (только для en-GB) joomla/joomla-cms#38570 + joomla/joomla-cms#38459 + joomla/joomla-cms#38451 + joomla/joomla-cms#38449 + joomla/joomla-cms#38313 + joomla/joomla-cms#38447 +

Razzo1987 · 2022-09-06T20:53:28Z

Also in

joomla-cms/language/en-GB/com_media.ini

Line 101 in 835d986

COM_MEDIA_SEARCH="Search..."

and

joomla-cms/administrator/language/en-GB/plg_task_checkfiles.ini

Line 14 in 835d986

    
           PLG_TASK_CHECK_FILES_LOG_RESIZE_FAIL="Failed to resize image due to an error in plugin logic..."

brianteeman · 2022-09-06T21:07:15Z

@Razzo1987 thanks - see #38710

HLeithner · 2022-09-07T06:13:00Z

What's the reason why you use the html encoding & hellip ; instead of the utf8 character … ?

brianteeman · 2022-09-07T06:46:07Z

Clarity.

HLeithner · 2022-09-07T07:56:10Z

can we please change this because this would not work in cli script or non-browser context, afaik is that we try to avoid html encoding in language files and use utf8 directly (it's done for easy writing)

brianteeman · 2022-09-07T08:06:39Z

No I will not change it and we have plenty of html in our strings.

&hellip is easier to type and visually an editor will not mistakenly type ... when they mean …

As already explained we must use an ellipsis for accessibility and changing to use the utf8 … from the ... will not help as translators etc will not SEE that they are different and will continue to type ... especially as its much easier to type ... than it is to look up the utf8 character. It's certainly easier for me to type &hellip than it is to open a character map and locate the utf8 map and then locate the ellipsis and insert it into a document

brianteeman · 2022-09-07T08:15:42Z

which of those is the real ellipsis

HLeithner · 2022-09-07T09:18:33Z

That one which also works outside of a webbrowser.

HLeithner · 2022-09-07T09:19:56Z

OK so the Unicode consortium are all idiots and we should go back to ascii and HTML encoding. Makes sense to me.

HLeithner · 2022-09-07T09:25:48Z

forget the "idiots", I already argument like other people in this tracker and that makes it sick. People are doing anyway what they want to do so I should not take this personally and look at my health.

brianteeman · 2022-09-07T09:30:08Z

I know many of the unicode consortium, spoken at their conference twice, nice people. However, unfortunately, much of their work is not accessible at all or more accurately is misused and is therefore not accessible and we have no control/influence on how the different screen reader applications work. - they're all different to each other most of the time.

brianteeman · 2022-09-07T09:59:05Z

No one was forced to merge this

N6REJ · 2022-09-08T03:30:49Z

is it possible to add the … to tiny as I'm darn sure never going to remember that and I use ... almost hourly

brianteeman · 2022-09-08T06:30:08Z

What does that have to do with changing language strings?

@HLeithner

**I was wrong and should have listened more to what @HLeithner was saying.** He was obviously correct that you can't use &hellip, in a language string in the cli. I still think the lack of readability of using utf characters in a search string is an issue so I have reverted the use to ... I have also reviewed all the other changes that I made in that PR and instead of reverting I am removing the … as it really served no purpose As far as I can see now the remaining uses from that PR all relate to Read more where I still believe it is best to use &hellip but I would be happy to revert those as well. Sorry for causing this issue. I am not sure if we are in a freeze for strings in 4.2 so if required I can rebase to 4.3

joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Aug 30, 2022

tecpromotion reviewed Aug 30, 2022

View reviewed changes

administrator/language/en-GB/joomla.ini Outdated Show resolved Hide resolved

tecpromotion reviewed Aug 30, 2022

View reviewed changes

api/language/en-GB/joomla.ini Outdated Show resolved Hide resolved

tecpromotion requested changes Aug 30, 2022

View reviewed changes

brianteeman and others added 2 commits August 30, 2022 09:28

Update administrator/language/en-GB/joomla.ini

c0bc0e0

Co-authored-by: Stefan Wendhausen <[email protected]>

Update api/language/en-GB/joomla.ini

56ac93c

Co-authored-by: Stefan Wendhausen <[email protected]>

tecpromotion approved these changes Aug 30, 2022

View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 30, 2022

Merge branch '4.2-dev' into ellipsi_strings

bfa6ccd

roland-d merged commit 6031e24 into joomla:4.2-dev Aug 31, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 31, 2022

roland-d added this to the Joomla! 4.2.2 milestone Aug 31, 2022

brianteeman deleted the ellipsi_strings branch August 31, 2022 20:47

jgerman-bot mentioned this pull request Sep 1, 2022

Use ellipsis - part 1 joomlagerman/joomla#2569

Closed

joomlapl-bot mentioned this pull request Sep 1, 2022

Use ellipsis - part 1 JoomlaPolska/jezyk-J4#228

Closed

brianteeman mentioned this pull request Sep 6, 2022

ellipsis part 2 #38710

Closed

Uh oh!

Use ellipsis - part 1 #38638

Use ellipsis - part 1 #38638

Uh oh!

Conversation

brianteeman commented Aug 30, 2022

Uh oh!

Uh oh!

Uh oh!

tecpromotion left a comment

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Aug 30, 2022

Uh oh!

tecpromotion left a comment

Choose a reason for hiding this comment

Uh oh!

tecpromotion commented Aug 30, 2022

Uh oh!

N6REJ commented Aug 30, 2022

Uh oh!

brianteeman commented Aug 30, 2022

Uh oh!

Quy commented Aug 30, 2022

Uh oh!

Quy commented Aug 30, 2022

Uh oh!

N6REJ commented Aug 31, 2022

Uh oh!

brianteeman commented Aug 31, 2022

Uh oh!

roland-d commented Aug 31, 2022

Uh oh!

brianteeman commented Aug 31, 2022

Uh oh!

Razzo1987 commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Sep 6, 2022

Uh oh!

HLeithner commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Sep 7, 2022

Uh oh!

HLeithner commented Sep 7, 2022

Uh oh!

brianteeman commented Sep 7, 2022

Uh oh!

brianteeman commented Sep 7, 2022

Uh oh!

HLeithner commented Sep 7, 2022

Uh oh!

HLeithner commented Sep 7, 2022

Uh oh!

HLeithner commented Sep 7, 2022

Uh oh!

brianteeman commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Sep 7, 2022

Uh oh!

N6REJ commented Sep 8, 2022

Uh oh!

brianteeman commented Sep 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Razzo1987 commented Sep 6, 2022 •

edited

Loading

HLeithner commented Sep 7, 2022 •

edited

Loading

brianteeman commented Sep 7, 2022 •

edited

Loading