metis-menu css logical proprties#38359
Merged
fancyFranci merged 2 commits intojoomla:4.2-devfrom Jan 7, 2023
Merged
Conversation
There is no need to add this conditional css for rtl when we can just use logical css properties instead. The original PR that added this was joomla/cassiopeia#243 code review should be fine
joomla-cms-bot
added
NPM Resource Changed
drmenzelit
approved these changes
Sep 9, 2022
Contributor
|
I just did a code review - looks fine. |
Contributor
|
I have tested this item ✅ successfully on 25c596b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38359. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38359. |
Contributor
|
Much better! Thank you |
Contributor
Author
|
Thanks |
charvimehradu
pushed a commit
to charvimehradu/joomla-cms
that referenced
this pull request
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to add this conditional css for rtl when we can just use logical css properties instead.
The original PR that added this was joomla/cassiopeia#243
code review should be fine