Skip to content

Fire the change event consistently#37702

Closed
dgrammatiko wants to merge 2 commits intojoomla:4.1-devfrom
dgrammatiko:4.1-dev
Closed

Fire the change event consistently#37702
dgrammatiko wants to merge 2 commits intojoomla:4.1-devfrom
dgrammatiko:4.1-dev

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue #37640 .

Summary of Changes

  • Call the Custom Element function setValue instead of manually updating the value

Testing Instructions

  • Edit an article and go to the images tab
  • Open the inspector and inspect the intro image input (the one left to the select button bellow the image)
  • type in the browser's console $0.addEventListener('change', (e) => console.log(e))
  • Select an image, check that a change event was recorded in the console
  • Clear the field, check the recorded event
  • Select another image and check that the event was recorded again

Actual result BEFORE applying this Pull Request

No event on image selection

Expected result AFTER applying this Pull Request

Documentation Changes Required

No this is a bug

BTW this is already fixed in 4.2 with #37654 and merging this will not end up in conflicts when syncing the 2 repos.

@dgrammatiko dgrammatiko closed this Jun 6, 2022
@dgrammatiko dgrammatiko deleted the 4.1-dev branch June 6, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants