[4.2] Allow typing in media field

[dgrammatiko]

Pull Request for Issue # . Replaces #36945

Summary of Changes

• Removes the readonly attribute from the input of Media Field so users could type freely
• It doesn't fix the preview for EXTERNAL urls (out of scope)

Testing Instructions

• Create a new article and add some title
• go to the images tab
• type (or copy paste) images/sampledata/cassiopeia/not-valid.jpg
• save the form
• type (or copy paste) images/sampledata/cassiopeia/nasa1-400.jpg
• Save the form (observe that the image url has the # parts!!!!)
• type (or copy paste) /images/sampledata/cassiopeia/nasa1-400.jpg
• save the form (observe the URL)
• type (or copy paste) any valid external URL
• save the form

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

[coolcat-creations]

@dgrammatiko I tested the patch and typing is possible but it does not update the preview after typing in / pasting the desired path

• the # are not added - should they be added with the patch? I am testing on localhost with the patchtester

[dgrammatiko]

did you read the description? Also what is the url you're entering?

I am testing on localhost with the patchtester

Yeah that won't work, try d/l the package at the end of this PR (GitHub)

[coolcat-creations]

Yes I read the description - maybe I misunderstood them or the issue is because i used patchtester. I will try with the prebuild package then. Thank you

[coolcat-creations]

I installed now the prebuilt package and it works mostly like expected.
Only mostly because I succeeded to break it like that, that now the not valid message appears despite I chosed an image in the modal. (Also after hitting save)

[dgrammatiko]

@coolcat-creations should be fine now

[coolcat-creations]

I have tested this item ✅ successfully on 048f033


type (or copy paste) images/sampledata/cassiopeia/not-valid.jpg - done works (Validation message displayed)

type (or copy paste) images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)

type (or copy paste) /images/sampledata/cassiopeia/nasa1-400.jpg - done works (#parts added)

type (or copy paste) any valid external URL - done and works (image previewed, no # parts added as expected)

Thank you very much!!!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.}

[richard67]

@coolcat-creations Could you test this PR again? It has received some changes after your last test. Thanks in advance.

[RickR2H]

@dgrammatiko Thanks for looking into this. Much appreciated!

I noticed that when I select the image via the select button I get: images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=50 But when I paste the URL like this: images/joomla_black.png I get the URL images/joomla_black.png#joomlaImage://local-images/joomla_black.png?width=225&height=225

Ik looks like when pasting the URL the exact image width and height are not respected and the image is default defined as squared.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.}

[dgrammatiko]

Ik looks like when pasting the URL the exact image width and height are not respected and the image is default defined as squared

The wrong variable was passed fro the height, it should be ok after cf77958

[coolcat-creations]

Good catch! did not see this. I will test now as well ... waiting for the new prebuilt package :)

[RickR2H]

I have tested this item ✅ successfully on cf77958

Thanks @dgrammatiko

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.}

[coolcat-creations]

I have tested this item ✅ successfully on cf77958

Thank you, tested successful as the given testing instructions.

The Preview seems not to work for svg tough but I think thats another issue

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.}

[RickR2H]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37654.}

[roland-d]

Thanks everybody