-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.1] com_media: hardcoded language strings #37588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I may be wrong but my undeerstanding was that exception messages were not being translated |
|
I found the hard coded text when I was looking for the "Media Provider not found" that a J4 user reported to me when they tried to use Media as Custom Field Type. If a decision was made to not translate exception messages, then that could explain why these strings weren't translated yet :-) |
|
It appears to be inconsistent even within the same file and peersonally I don't understand why everything isnt a translatable string. For example cheeck out https://github.com/joomla/joomla-cms/blob/4.1-dev/plugins/filesystem/local/src/Adapter/LocalAdapter.php |
|
A basic rule should be that the API throws a specific exception and the representation layer should catch it and display a meaningful error message. We tried to do this in the local adapter with the |
|
some? 12/15 is not some |
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: Brian Teeman <[email protected]>
|
Thanks @brianteeman! |
|
I have tested this item ✅ successfully on 9a915cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588. |
|
Thanks. If this PR gets accepted, then I'll fix more of those hard coded Exception errors in components when I find them. |
|
I have tested this item ✅ successfully on 9a915cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37588. |
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
The admin component com_media had some hard coded English texts.
Summary of Changes
This PR changes the hard coded English texts to language strings
and adds the translations to administrator/language/en-GB/com_media.ini