-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.1] Unnecessary description for layout #37564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please deprecate the language string and don't remove it please |
|
@HLeithner, so will it be right (copy/paste from 3.10)?
|
|
Please NO |
Be specific. What exactly is NO? |
|
please no for marking it as deprecated |
what else would you like to do with the string? |
|
if its not being used then remove it. which is exactly whats happened to date in j4 |
|
|
I changed the PR as requested above. Although, of course, it is strange to apply rule 6.1.6 only to some PRs. Considering that 3.x modules could theoretically work on 4.x, which uses a lot of |
|
I have tested this item ✅ successfully on 7c6eba3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564. |
1 similar comment
|
I have tested this item ✅ successfully on 7c6eba3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564. |
Co-authored-by: Allon Moritz <[email protected]>
Co-authored-by: Allon Moritz <[email protected]>
|
Thanks! |
joomla/joomla-cms#37115 + joomla/joomla-cms#37286 + (отдельно в 857dcac) joomla/joomla-cms#37464 + joomla/joomla-cms#36250 + joomla/joomla-cms#37527 + joomla/joomla-cms#37535 - (только для en-GB) joomla/joomla-cms#37559 + joomla/joomla-cms#37594 - (только для en-GB) joomla/joomla-cms#37588 + joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями) joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#37564 + joomla/joomla-cms#37641 - (только для en-GB) joomla/joomla-cms#37657 + joomla/joomla-cms#37683 + joomla/joomla-cms#37666 + joomla/joomla-cms#37704 + joomla/joomla-cms#37689 + joomla/joomla-cms#37519 +
Pull Request for Issue # .
Summary of Changes
In 95% of modules for the control panel, the description for the LAYOUT parameter was previously removed.
The PR removes the last 2.
In the "Login Support Information" module, the "Automatic Title" parameter has been moved 1 param lower, as it corresponds to the position in the other modules.