Skip to content

Conversation

@Kostelano
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

In 95% of modules for the control panel, the description for the LAYOUT parameter was previously removed.

Screenshot_1

The PR removes the last 2.

In the "Login Support Information" module, the "Automatic Title" parameter has been moved 1 param lower, as it corresponds to the position in the other modules.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels Apr 15, 2022
@HLeithner
Copy link
Member

Please deprecate the language string and don't remove it please

@Kostelano
Copy link
Contributor Author

@HLeithner, so will it be right (copy/paste from 3.10)?

; Deprecated, will be removed with 5.0. Please do not translate the following language string

@brianteeman
Copy link
Contributor

Please NO

@Kostelano
Copy link
Contributor Author

Please NO

Be specific. What exactly is NO?

@brianteeman
Copy link
Contributor

please no for marking it as deprecated

@HLeithner
Copy link
Member

please no for marking it as deprecated

what else would you like to do with the string?

@brianteeman
Copy link
Contributor

if its not being used then remove it. which is exactly whats happened to date in j4

@HLeithner
Copy link
Member

if its not being used then remove it. which is exactly whats happened to date in j4

6.1.6 Language keys
Changing or deleting a language key is considered a backwards compatibility break. Adding new ones is not. Substantially changing the meaning associated with a language key is a compatibility break. Rephrasing something for a more accurate description or proper en-GB grammar is not.

@Kostelano
Copy link
Contributor Author

I changed the PR as requested above. Although, of course, it is strange to apply rule 6.1.6 only to some PRs.

Considering that 3.x modules could theoretically work on 4.x, which uses a lot of _DESC strings (including this one), it would probably be more correct.

@Quy
Copy link
Contributor

Quy commented Apr 19, 2022

I have tested this item ✅ successfully on 7c6eba3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.

1 similar comment
@Shubhamverma2796
Copy link
Contributor

I have tested this item ✅ successfully on 7c6eba3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.

@Quy
Copy link
Contributor

Quy commented Apr 20, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37564.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 20, 2022
@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 24, 2022
@Kostelano Kostelano requested a review from laoneo April 24, 2022 20:07
@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 25, 2022
@laoneo laoneo merged commit 3a9e3fa into joomla:4.1-dev Apr 25, 2022
@laoneo
Copy link
Member

laoneo commented Apr 25, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 25, 2022
@Kostelano Kostelano deleted the 4-1-layout-desc branch April 25, 2022 08:45
@zero-24 zero-24 added this to the Joomla 4.1.3 milestone Apr 25, 2022
Kostelano added a commit to JPathRu/localisation that referenced this pull request May 2, 2022
joomla/joomla-cms#37115 +
joomla/joomla-cms#37286 + (отдельно в 857dcac)
joomla/joomla-cms#37464 +
joomla/joomla-cms#36250 +
joomla/joomla-cms#37527 +
joomla/joomla-cms#37535 - (только для en-GB)
joomla/joomla-cms#37559 +
joomla/joomla-cms#37594 - (только для en-GB)
joomla/joomla-cms#37588 +
joomla/joomla-cms#37424 - (только для en-GB, у нас все в одном формате с другими расширениями)
joomla/joomla-cms#37475 - (только для en-GB, у нас давно исправлено)
joomla/joomla-cms#37564 +
joomla/joomla-cms#37641 - (только для en-GB)
joomla/joomla-cms#37657 +
joomla/joomla-cms#37683 +
joomla/joomla-cms#37666 +
joomla/joomla-cms#37704 +
joomla/joomla-cms#37689 +
joomla/joomla-cms#37519 +
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants