-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] Indicate if category not published #37583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like a good idea, I think this is something we should add and can be added to the next minor version. |
|
one addition: maybe better to solve this in the PublishedButton class. Then you only have to fix it one time and not in all views. Could be something like "Published but category unpublished or trashed" |
|
@rdeutz That was my first thought but then it gets complicated by workflows |
|
@rdeutz took another look but I dont see how to do it in the class as it is not aware of the category |
|
@rdeutz do you have any pointers as to how to solve it in the PublishedButton. If not I will continue with this approach. |
|
I looked at the class and (beside Workflow, I don't see how this effects the buttom but maybe I missed something) it should be doable. I will check over the weekend and let you know. |
|
@rdeutz thanks |
|
This should do the trick: rdeutz@847c041 |
as even your code requires a chang in the view I decided to combin the two |
|
I have tested this item ✅ successfully on d3bd885 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583. |
|
I have tested this item ✅ successfully on d3bd885 Expected behaviour when category is unpublished or trashed. It works in Featured Articles list too. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37583. |
|
I really like this PR, but it will not make it in 4.1, but for sure in 4.2! Thanks for the improvement. |
|
JFYI: the "too much files" will be fixed on Tuesday, then there will be the next upmerge from 4.1 (which is already in your branch) after the relese of J! 4.2 Alpha 2. Then we're back to normal (no additional human tests needed). |
|
No problem |
|
Thanks everybody |
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
Articles that are in a category which is unpublished or trashed are not visible on the site but there is no way you can tell this from the article manager
Summary of Changes
Testing Instructions
Create a catgory called test and create 4 featured articles in that category.
Unpublish or Trash the category
Check the list of articles and the list of featured articles
Actual result BEFORE applying this Pull Request
No indication that the article can not be displayed
Expected result AFTER applying this Pull Request
Text as shown in the image below
Documentation Changes Required