Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Apr 24, 2022

Summary of Changes

  1. Adds an indicator if the category is unpublished or trashed.
  2. Changes the published icon to a disabled icon and adds a tooltip to the icon
  3. changes to use the publishedbutton and featuredbutton

Testing Instructions

Create a category called test and create 4 featured contacts in that category.
Unpublish or Trash the category

Check the list of contacts

Actual result BEFORE applying this Pull Request

No indication that the contact can not be displayed

Expected result AFTER applying this Pull Request

Text as shown in the image below

image

### Summary of Changes
1. Adds an indicator if the category is unpublished or trashed.
2. Changes the published icon to a disabled icon and adds a tooltip to the icon
3. changes to use the publishedbutton and featuredbutton

### Testing Instructions
Create a category called test and create 4 featured contacts in that category.
Unpublish or Trash the category

Check the list of contacts

### Actual result BEFORE applying this Pull Request
No indication that the contact can not be displayed

### Expected result AFTER applying this Pull Request
Text as shown in the image below
@brianteeman brianteeman marked this pull request as ready for review April 26, 2022 19:21
@toivo
Copy link
Contributor

toivo commented Apr 30, 2022

I have tested this item 🔴 unsuccessfully on a959bef

Tested in Joomla 4.2.0-alpha3-dev of 30 April.

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed). When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37631.

@brianteeman
Copy link
Contributor Author

Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed).

So that is the correct and expected behaviour of this pr

When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised.

That is beyond the scope of this PR. This PR is only for the list view

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev.

@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the checkcontact branch September 8, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants