-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.2] contacts - Indicate if category not published #37631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
### Summary of Changes 1. Adds an indicator if the category is unpublished or trashed. 2. Changes the published icon to a disabled icon and adds a tooltip to the icon 3. changes to use the publishedbutton and featuredbutton ### Testing Instructions Create a category called test and create 4 featured contacts in that category. Unpublish or Trash the category Check the list of contacts ### Actual result BEFORE applying this Pull Request No indication that the contact can not be displayed ### Expected result AFTER applying this Pull Request Text as shown in the image below
|
I have tested this item 🔴 unsuccessfully on a959bef Thrashed the category and the contact list http://joomla42/administrator/index.php?option=com_contact&view=contacts shows the contacts as Published, Category: Test (Trashed). When each contact is checked through administrator/index.php?option=com_contact&view=contact&layout=edit&id=1, each contact is shown Published but belonging to the category Uncategorised. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37631. |
So that is the correct and expected behaviour of this pr
That is beyond the scope of this PR. This PR is only for the list view |
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
|
This pull request has been automatically rebased to 5.0-dev. |
Summary of Changes
Testing Instructions
Create a category called test and create 4 featured contacts in that category.
Unpublish or Trash the category
Check the list of contacts
Actual result BEFORE applying this Pull Request
No indication that the contact can not be displayed
Expected result AFTER applying this Pull Request
Text as shown in the image below