Fix article save2copy not unpublished

[kitepascal]

Pull Request for Issue #37351 .

Summary of Changes

Testing Instructions

Save as Copy

Actual result BEFORE applying this Pull Request

Article is published.

Expected result AFTER applying this Pull Request

Article shoud be unpublished like in J3 before.

Documentation Changes Required

None.

Fixes #37351

[toivo]

I have tested this item ✅ successfully on b17c1c5

Tested successfully in 4.1.1-rc2-dev of 23 March using PHP 8.0.15

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37354.}

[Shubhamverma2796]

I have tested this item ✅ successfully on b17c1c5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37354.}

[brianteeman]

I am a little unsure that this is the correct fix. It would be useful to find out when/where the j3 behaviour was changed. Was there a reason for it, was anything else changed at the same time. There may be more needed than just this one line.

[richard67]

I am a little unsure that this is the correct fix. It would be useful to find out when/where the j3 behaviour was changed. Was there a reason for it, was anything else changed at the same time. There may be more needed than just this one line.

Yes, I have the same feeling, but I'm at work so can't investigate. I hope someone else can step in if necessary.

[brianteeman]

Well there is no rush to merge it ;)

Thinking aloud but it might be something to do with the creation of multilingual associated articles

[kitepascal]

it might be something to do with the creation of multilingual associated articles

Created multilingual associated articles are still published initially, just tested that.
Also if you create an associated translation of an unpublished article.

[laoneo]

Perhaps @bembelimen can shed some light in here as it can relate to the workflow changes.

[richard67]

Perhaps @bembelimen can shed some light in here as it can relate to the workflow changes.

I think that could be the point. When workflow is enabled, it should use the default stage, which might be different. Maybe we should look up in the code how it's done for batch copying?

[bembelimen]

Workflow didn't change the behaviour... I wanted to do so, but there was too much restistant and for me it was not worth the time to fight for it...so I think copy should always save unpublished, but that is just my opinion.

[brianteeman]

Well something changed it - weird

[HLeithner]

This pull request has automatically rebased to 4.2-dev.

[joomla-bot]

This pull requests has been automatically converted to the PSR-12 coding standard.

[Quy]

Closing in favor of #38810 as it has more in-depth discussion. Thank you for your contribution.