[J 4.1.x] Save as copy saves article published

[coolcat-creations]

Steps to reproduce the issue

In the previous Joomla version Save as Copy task saved the article as copy but unpublished
Now the Save as Copy task automatically publishes the article

Expected result

When do you want to save something as a copy? Probably when you want to take the existing one as a draft for the next one. In this case you would not want to have it published until you are finished with your editing. In Joomla 4 somehow this changed.

Actual result

When you open an article and click on the Save as Copy Button, the copy is created and published.

System information (as much as possible)

Joomla 4.1.0

Additional comments

Reported by Dominik on Facebook, I agree that this is not user friendly

[richard67]

From steps to reproduce the issue:

Not the Save as Copy task automatically publishes the article

@coolcat-creations I think you meant „Now“ and not „Not“. Am I right?

[coolcat-creations]

Thank you @richard67 - updated!

[chmst]

@coolcat-creations thanks for reporting. that's surely not intended, as in modules the copy also is unpublished.

[brianteeman]

.. and batch actions copy is also unpublished

[kitepascal]

.. and batch actions copy is also unpublished

For batch actions that's reasonable.
The batch copies are intended to be edited before publishing.

In edit view, from the logical side, a copy is a copy with copied parameters, 1:1, form saved like selected (can be changed before hitting the button).
First thing I did in J3 was to publish the "Save as Copy" but unpublished copy or menu item.

Out of habit, the old behaviour is also fine. It should be consistent between articles and modules.

[chmst]

You cannot make everyone happy. I think whatever is done here will be returned in a following PR.

[kitepascal]

I'm very unhappy about still not being able to do a single line PR without issues.
I did not get it to detach the former commits through browser. Sorry for that! 💁🏻‍♂️

[richard67]

I'm very unhappy about still not being able to do a single line PR without issues.
I did not get it to detach the former commits through browser. Sorry for that! 💁🏻‍♂️

@kitepascal You are talking about #37354 ? It looks ok.

[richard67]

Closing as having a pull request.

[richard67]

@kitepascal I think your problem was that you have used your 4.1-dev branch for the PR, and that branch had other changes before. It is better to create a new, dedicated branch based on the 4.1-dev branch of the upstream repository (= this one here from the point of view of your fork) for each PR.