[4.0] PHP 8.1 deprecation notices various #36362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on 318edec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36362. |
HLeithner
reviewed
Dec 22, 2021
Contributor
Author
|
@HLeithner Sorry. I put the PunicodeHelper in the library PR instead of here. |
Contributor
Author
|
This looks a bit suspicious in the api-test
|
Member
|
Can you update tge Branch please |
Contributor
Author
|
Sorry. I don't understand. |
Member
|
merge the current 4.0-dev branch with this pr branch |
Member
|
I have tested this item ✅ successfully on c93dd56 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36362. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Patching PHP 8.1 deprecation notices where null is provided instead of 'something'.
Testing Instructions
Code review or checking logs.
Actual result BEFORE applying this Pull Request
Deprecation notices
Expected result AFTER applying this Pull Request
No deprecation notices from these files.
Documentation Changes Required
Probably not.