Skip to content

Conversation

@HLeithner
Copy link
Member

See title

@HLeithner
Copy link
Member Author

For unknown reason media manager fails...

@Fedik
Copy link
Member

Fedik commented Dec 8, 2021

I think it may be due to ajax request fail,
I see there many deprecate notices, one of them could break the body of ajax response

@HLeithner
Copy link
Member Author

it also fails with 7.2 (phpmin) (with the new images, not sure if the last update changed anything since the last build)

@wilsonge
Copy link
Contributor

Updated this branch a few times as I've merged in some of the 8.1 fixes in case.

@wilsonge
Copy link
Contributor

wilsonge commented Dec 13, 2021

The test fail is super weird. It creates a new folder (NOT via the UI - but by a PHP function (which is also used to create the test-dir that all the tests work from - so it must work)). Then it goes to the UI and tries to rename the folder. But the new sub-folder created doesn't show up in the UI - so it can't rename it and so fails.

FWIW I can confirm that this specific test does work in PHP 8.1 too on my local setup :)

@wilsonge
Copy link
Contributor

No figured it out. You changed the install directory to be db folder specific but didn't update https://github.com/joomla/joomla-cms/pull/36260/files#diff-d43be3f113ad505ac2e42c4da89933bbd1e25cee518586ecbf04156bcae55144R44 @HLeithner - just needs that overriding for each DB type now

use Page\Acceptance\Administrator\MediaListPage;
use PHPUnit\Framework\Assert;

use function print_r;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function is not used

@wilsonge
Copy link
Contributor

@HLeithner still a bit ugly - but this works

@wilsonge
Copy link
Contributor

Screenshot 2021-12-17 at 00 17 58

The current test fail matches my local setup results for PHP 8.1 - so I'd say this is now "working as expected"

@HLeithner
Copy link
Member Author

At least it works. The deprecation should be fixed before we merge this ;-)

@wilsonge
Copy link
Contributor

Can you add an allowed fail for the phpmax system tests? I'd like to get this in and then I can start crossing failures out directly with system test proof

@HLeithner
Copy link
Member Author

@wilsonge tests are working now, I also added api tests for postgres and it seems it fails because of a bug https://ci.joomla.org/joomla/joomla-cms/49383/1/27

maybe @richard67 or @alikon can have a look?

I would merge it now and fix es problems later and remove the failure ignore when fixed.

@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Dec 22, 2021
@alikon
Copy link
Contributor

alikon commented Dec 22, 2021

@HLeithner HLeithner merged commit 110f381 into joomla:4.0-dev Dec 22, 2021
@HLeithner HLeithner deleted the tests/system-81 branch December 22, 2021 18:29
@zero-24 zero-24 added this to the Joomla 4.0.6 milestone Dec 23, 2021
@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues Unit/System Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants