-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add systemtests for php 8.1 #36260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemtests for php 8.1 #36260
Conversation
…tem-81 � Conflicts: � .drone.yml
|
For unknown reason media manager fails... |
|
I think it may be due to ajax request fail, |
|
it also fails with 7.2 (phpmin) (with the new images, not sure if the last update changed anything since the last build) |
|
Updated this branch a few times as I've merged in some of the 8.1 fixes in case. |
|
The test fail is super weird. It creates a new folder (NOT via the UI - but by a PHP function (which is also used to create the test-dir that all the tests work from - so it must work)). Then it goes to the UI and tries to rename the folder. But the new sub-folder created doesn't show up in the UI - so it can't rename it and so fails. FWIW I can confirm that this specific test does work in PHP 8.1 too on my local setup :) |
|
No figured it out. You changed the install directory to be db folder specific but didn't update https://github.com/joomla/joomla-cms/pull/36260/files#diff-d43be3f113ad505ac2e42c4da89933bbd1e25cee518586ecbf04156bcae55144R44 @HLeithner - just needs that overriding for each DB type now |
| use Page\Acceptance\Administrator\MediaListPage; | ||
| use PHPUnit\Framework\Assert; | ||
|
|
||
| use function print_r; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function is not used
|
@HLeithner still a bit ugly - but this works |
|
At least it works. The deprecation should be fixed before we merge this ;-) |
|
Can you add an allowed fail for the phpmax system tests? I'd like to get this in and then I can start crossing failures out directly with system test proof |
|
@wilsonge tests are working now, I also added api tests for postgres and it seems it fails because of a bug https://ci.joomla.org/joomla/joomla-cms/49383/1/27 maybe @richard67 or @alikon can have a look? I would merge it now and fix es problems later and remove the failure ignore when fixed. |
|
yes please merge this now |

See title