Skip to content

[4.0] Template tree rtl#36029

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:atem-logical-tree
Nov 28, 2021
Merged

[4.0] Template tree rtl#36029
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:atem-logical-tree

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Nov 14, 2021

This is a replacement to the merged PR #26367

It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version

There is no visual change.
image

This is a replacement to the merged PR joomla#6367

It does exactly the same thing but by using css logical properties we avoid the need to maintain both an LTR and an RTL version

There is no visual change.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Nov 14, 2021
@ceford
Copy link
Contributor

ceford commented Nov 24, 2021

Does this refer to the wrong previous PR? I don't know where to look to test this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36029.

@brianteeman
Copy link
Contributor Author

I had missed a digit. I have updated the original post now.

@ceford
Copy link
Contributor

ceford commented Nov 24, 2021

I have tested this item ✅ successfully on 52ae6bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36029.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Nov 24, 2021

I have tested this item ✅ successfully on 52ae6bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36029.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36029.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 24, 2021
@richard67 richard67 added the RMDQ ReleaseManagerDecisionQueue label Nov 24, 2021
@richard67
Copy link
Member

Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy.

@wilsonge wilsonge merged commit 49f44e9 into joomla:4.0-dev Nov 28, 2021
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 28, 2021
@wilsonge wilsonge added this to the Joomla 4.0.5 milestone Nov 28, 2021
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the atem-logical-tree branch November 28, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester RMDQ ReleaseManagerDecisionQueue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants