Skip to content

[4.0] RTL: Fixing template tree#26367

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_template_tree
Sep 24, 2019
Merged

[4.0] RTL: Fixing template tree#26367
wilsonge merged 3 commits intojoomla:4.0-devfrom
infograf768:4.0_template_tree

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Sep 21, 2019

Summary of Changes

Overriding _treeselect.scss by adding RTL specific css

Testing Instructions

Display Cassiopea template edit using Persian language or setting en-GB.xml to rtl

Before patch

treertlbefore

After patch

Screen Shot 2019-09-21 at 12 01 42

@Harmageddon
Copy link
Contributor

I have tested this item ✅ successfully on d0550e1

Works as advertised. Changed language to Persian, applied the patch and the tree view looks way better now.
(Note that I don't speak Persian or other RTL languages, so this comment is based on my assumption how I think it makes sense)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26367.

@infograf768
Copy link
Member Author

@richard67
can you also test this one?

@richard67
Copy link
Member

I have tested this item ✅ successfully on d0550e1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26367.

@infograf768
Copy link
Member Author

rtc
thNks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26367.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 21, 2019
@wilsonge wilsonge merged commit fe4eaba into joomla:4.0-dev Sep 24, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 24, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 24, 2019
@infograf768 infograf768 deleted the 4.0_template_tree branch September 24, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants