Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Oct 24, 2021

Followup pr of #35332.

Summary of Changes

As #35332 gets abandoned, this one here is a conflict fix. All the old commits should be preserved.

More information can be found in the pr #35332 by @JenSeReal.

Testing Instructions

Open media manager and execute the actions and browse around.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Oct 24, 2021
@richard67
Copy link
Member

@laoneo System test is failing, I've tried to restart several times now but it always fails at the same place, so maybe it's related to this PR: https://ci.joomla.org/joomla/joomla-cms/48082/1/22

It always fails at the test "Test that it is possible to navigate to a subfolder using double click.".

The screenshot from the test doesn't show anything special: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.1-dev/35887/system-tests/48082

@laoneo laoneo changed the title [4.1] Refactor vue brower items [4.1] Refactor vue browser items Oct 24, 2021
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 3379fcc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.

@chmst
Copy link
Contributor

chmst commented Nov 8, 2021

I have tested this item ✅ successfully on 3379fcc

Tested as a user, without inspecting the code and English language. From a uses point of view the PR works good, no errors or notices found.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.

@laoneo
Copy link
Member Author

laoneo commented Nov 8, 2021

RTC

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35887.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 8, 2021
@richard67 richard67 added this to the Joomla 4.1 milestone Nov 8, 2021
@richard67
Copy link
Member

Note for maintainers: When merging with a squash commit, don't remove the "co-authored by" tags in the commit description generated by GitHub so that the author of the original PR is not forgotten.

@wilsonge
Copy link
Contributor

wilsonge commented Nov 8, 2021

Can someone do some quick a11y validation on this one. I assume as we still have the unordered list it's ok. But some of the html here was refactored from divs to ul's originally for proper screenreader compat

@laoneo
Copy link
Member Author

laoneo commented Nov 12, 2021

@brianteeman can you have a look on the concern from @wilsonge?

@brianteeman
Copy link
Contributor

Please ask the accessibility team

@richard67
Copy link
Member

I will ping them on Glip.

@laoneo
Copy link
Member Author

laoneo commented Nov 12, 2021

@richard67 thanks

@dgrammatiko
Copy link
Contributor

Can someone do some quick a11y validation on this one.

@wilsonge there are no structural changes here. The same HTML markup just moved around. (or am I wrong?)

@richard67
Copy link
Member

@dgrammatiko The thing is that while this PR was in progress, changes on the code which is moved around by this PR have been made, and so there were conflicts which were resolved. I think George just wants to be sure that the other changes have been applied to this PR when the conflicts were solved.

@laoneo
Copy link
Member Author

laoneo commented Nov 12, 2021

The conflicts were created by me as by #35451. I'v fixed them already. There were no structural changes involved in the other pr. I had a second look here and indeed, there are no structural changes as far as I can see, it was before also a list.

@carcam
Copy link

carcam commented Nov 12, 2021

I can confirm there are no html structural changes from an a11y point of view. Whenever there should be a list, there is a list and no divs are involved. Also with this refactoring, checking the code and A11y fixes will be simpler as we will split longer code in vue components reusing the markup.

I do think this is a RTC!!

@richard67
Copy link
Member

Is is RTC already.

@laoneo
Copy link
Member Author

laoneo commented Nov 12, 2021

Thanks @carcam !!

@bembelimen bembelimen merged commit ee7deb9 into joomla:4.1-dev Nov 13, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 13, 2021
@bembelimen
Copy link
Contributor

Thx

@laoneo laoneo deleted the j4/refactor/vue/browser branch November 15, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.