[4.0] Set focus on input field in rename modal #35451
Conversation
joomla-cms-bot
added
NPM Resource Changed
|
@laoneo Could you fix codestyle errors reported here https://ci.joomla.org/joomla/joomla-cms/47244/1/21 ? Thanks in advance. |
|
@richard67 you don't have to report always on my pr's that some code styles are invalid. I'm checking them regularly and will fix asap. |
@laoneo Ok, good to know. Here I thought I should do that because the previous run of drone had failed for unrelated reasons already with the build and I had restarted it and then the cs error was reported for the first time. |
|
Would be better to spend the time for testing the pr's actually 😏 |
@laoneo There is no need to tell me that I am not testing PR's. Just check the tracker statistics for any period of your choice. |
|
I don't say that you don't test. Please do not change words. But posting a couple of minutes after drone is run the first time that the author should have a look is imo just a waste of time. |
administrator/components/com_media/resources/scripts/components/browser/items/directory.vue
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on b4f387e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451. |
1 similar comment
|
I have tested this item ✅ successfully on b4f387e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451. |
|
@wilsonge friendly reminder |
|
Thanks! |
* docker-compose for development * added pdf component and query for pdfs * added action items and created toggle * added action items and created toggle * fixed refs of vue components * fixed refs of vue components * working preview action item button * working download button and destuctured export * add delete & share component * add edit component * refactoring & typos * test items-container * testing action items container * fix edit items * working can edit * final refactoring for pull request * final refactoring for pull request * final refactoring for pull request * merged latest 4.1 dev * fixed eslint recommendations * fixed bug with preview * reverted package-lock.json * fix conflicts * Adapt code from #35451 * Update administrator/components/com_media/resources/scripts/components/browser/actionItems/actionItemsContainer.vue Co-authored-by: Brian Teeman <[email protected]> * Update administrator/components/com_media/resources/scripts/components/browser/actionItems/actionItemsContainer.vue Co-authored-by: Brian Teeman <[email protected]> * Update administrator/components/com_media/resources/scripts/components/browser/items/image.vue Co-authored-by: Brian Teeman <[email protected]> * cs * more cs * Restore doublce click handler Co-authored-by: Jens Plüddemann <[email protected]> Co-authored-by: Tom Weber <[email protected]> Co-authored-by: Brian Teeman <[email protected]>
7 participants
Summary of Changes
When opening the rename modal in the media manager the input field doesn't get the focus. Not sure if this is a regression of #23950. But it fixes it and also sets the focus back to the element when the dialog is closed.
Testing Instructions
Rename a folder in the media manager, either by keyboard or mouse and then close it.
Actual result BEFORE applying this Pull Request
Input has no focus and when closed it is lost.
Expected result AFTER applying this Pull Request
Focus should be again on the action list toggle.