Skip to content

[4.0] Fix Module Positions Filter #33856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021
Merged

[4.0] Fix Module Positions Filter #33856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions administrator/components/com_modules/src/View/Modules/HtmlView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,35 @@ public function display($tpl = null)
$this->setLayout('emptystate');
}

/**
* The code below make sure the remembered position will be available from filter dropdown even if there are no
* modules available for this position. This will make the UI less confusing for users in case there is only one
* module in the selected position and user:
* 1. Edit the module, change it to new position, save it and come back to Modules Management Screen
* 2. Or move that module to new position using Batch action
*/
if (count($this->items) === 0 && $this->state->get('filter.position'))
{
$selectedPosition = $this->state->get('filter.position');
$positionField = $this->filterForm->getField('position', 'filter');

$positionExists = false;

foreach ($positionField->getOptions() as $option)
{
if ($option->value === $selectedPosition)
{
$positionExists = true;
break;
}
}

if ($positionExists === false)
{
$positionField->addOption($selectedPosition, ['value' => $selectedPosition]);
}
}

// Check for errors.
if (count($errors = $this->get('Errors')))
{
Expand Down