Skip to content

Conversation

@joomdonation
Copy link
Contributor

@joomdonation joomdonation commented May 14, 2021

Pull Request for Issue # .

Summary of Changes

See #33763 (comment) to understand the issue which this PR tries to solve. Basically, on Modules management screen, if you filter module by certain position which only has one module and you:

  • Move that module to new position using batch action
  • Or edit the module, change it to a new position

After doing the action, you will be redirected back to Modules management screen with no modules displayed and also, no position selected in the filter. You would think that it is confusing because you do not have anything in the filter, why there are no modules at all?

This PR just tries to fix that special case by make sure the selected/remember position will be available and selected in the dropdown so that you know the reason why there is no modules being displayed.

Testing Instructions

  1. Access to Modules Management from backend
  2. Try to select a position which only has one module (for example), banner position
  3. Edit the module, change the position to a different position, save it
  4. You will now being redirected to Modules Management screen
  5. Before patch, you will see a screen like below (note that there is no position selected in the position filter)
  6. After patch, the previous selected position will selected in the filter (so that you know why there is no modules - it is because you are filtering modules by that position)

Actual result BEFORE applying this Pull Request

no-modules_no_filter

Expected result AFTER applying this Pull Request

no_modules_filter_displayed

Additional Comments

I'm unsure if it is really needed. But since it is reported and I see that the UI is confusing for this case, so I make a PR to address it anyway. I have no problem if this PR is rejected :)

@chmst
Copy link
Contributor

chmst commented May 14, 2021

I have tested this item ✅ successfully on 6de3d21

This PR resolves the UX issue.
The issue is caused by the concept of positions, which as such are not stored in the database but exist only as a name in com_modules.
While from a devlopers point of view, everything was correct, it was confusing for users.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

@ghost
Copy link

ghost commented May 14, 2021

I have tested this item ✅ successfully on 6de3d21

@joomdonation for a user this is really needed :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

@joomdonation
Copy link
Contributor Author

Thanks both :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 14, 2021
@rdeutz rdeutz merged commit f1aebf3 into joomla:4.0-dev May 14, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 14, 2021
@joomdonation joomdonation deleted the module_positions_filter_fix branch May 14, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants