-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] fix position of Joomla button in Atum header #33719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… like in login.php
|
I can't find a difference in the screenshots of |
|
@sandramay0905
Because there is no difference in sight... just in HTML. |
@richard67 turns out to be true indeed. |
|
I have tested this item ✅ successfully on 723eb94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719. |
1 similar comment
|
I have tested this item ✅ successfully on 723eb94 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719. |
|
Thanks |

Pull Request for Issue # .
Summary of Changes
PR #33654 fixed the placement of Joomla button on the first row.
Caused an unwanted styling bug on com_foo
PR #33689 fixed the styling bug on com_foo
Caused the fix from the first PR
This PR also moves some php blocks to equalize the structure of error_login.php, error_full.php and login.php
Testing Instructions
http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw
Actual result BEFORE applying this Pull Request
administrator/index.php?option=com_foo
administrator/index.php?option=com_banners&task=tracks.display&format=raw
Expected result AFTER applying this Pull Request
administrator/index.php?option=com_foo
administrator/index.php?option=com_banners&task=tracks.display&format=raw
Documentation Changes Required