Skip to content

Conversation

@hans2103
Copy link
Contributor

@hans2103 hans2103 commented May 9, 2021

Pull Request for Issue # .

Summary of Changes

PR #33654 fixed the placement of Joomla button on the first row.
Caused an unwanted styling bug on com_foo
PR #33689 fixed the styling bug on com_foo
Caused the fix from the first PR

This PR also moves some php blocks to equalize the structure of error_login.php, error_full.php and login.php

Testing Instructions

Actual result BEFORE applying this Pull Request

administrator/index.php?option=com_foo

Schermafbeelding 2021-05-09 om 22 29 55

administrator/index.php?option=com_banners&task=tracks.display&format=raw

Schermafbeelding 2021-05-09 om 21 57 28

Expected result AFTER applying this Pull Request

administrator/index.php?option=com_foo

Schermafbeelding 2021-05-09 om 22 29 55

administrator/index.php?option=com_banners&task=tracks.display&format=raw

Schermafbeelding 2021-05-09 om 22 06 45

Documentation Changes Required

@ghost
Copy link

ghost commented May 10, 2021

I can't find a difference in the screenshots of administrator/index.php?option=com_foo before and after pull request.

@hans2103
Copy link
Contributor Author

@sandramay0905

I can't find a difference in the screenshots of administrator/index.php?option=com_foo before and after pull request.

Because there is no difference in sight... just in HTML.

@sandewt
Copy link
Contributor

sandewt commented May 10, 2021

Actual result BEFORE applying this Pull Request
Note the black text ! Ignore ?

issue-33917

@richard67
Copy link
Member

@sandewt The black text should have been fixed with PR #33654 2 days ago. Maybe your testing environment hasn't been updated to that yet?

@sandewt
Copy link
Contributor

sandewt commented May 10, 2021

@sandewt The black text should have been fixed with PR #33654 2 days ago.

@richard67 turns out to be true indeed.

@sandewt
Copy link
Contributor

sandewt commented May 10, 2021

I have tested this item ✅ successfully on 723eb94


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.

1 similar comment
@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on 723eb94


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.

@drmenzelit
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33719.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 10, 2021
@drmenzelit drmenzelit added this to the Joomla 4.0 milestone May 10, 2021
@chmst chmst merged commit 92aa075 into joomla:4.0-dev May 11, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2021
@chmst
Copy link
Contributor

chmst commented May 11, 2021

Thanks

@hans2103 hans2103 deleted the feature/atum-header branch May 11, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants