Skip to content

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented May 8, 2021

Pull Request for Issue #33599 #33612 .

Summary of Changes

Defines defaults for template color variables / Fixes header btn alignment.

Testing Instructions

Logout of Joomla 4 admin
Go to a URL that generates a 403 Forbidden message - here is a quick example:

http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@richard67
Copy link
Member

@ciar4n Do I assume right that this PR also makes PR #33649 obsolete?

@ciar4n
Copy link
Contributor Author

ciar4n commented May 8, 2021

Yes I think so... the header button alignment is fixed here

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

1 similar comment
@hans2103
Copy link
Contributor

hans2103 commented May 8, 2021

I have tested this item ✅ successfully on ca8daa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 8, 2021
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ca8daa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.

@Quy Quy merged commit ddc1380 into joomla:4.0-dev May 8, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 8, 2021
@Quy
Copy link
Contributor

Quy commented May 8, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants