Skip to content

Update README.md for unit tests#32758

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
astridx:patch-1
Mar 21, 2021
Merged

Update README.md for unit tests#32758
wilsonge merged 5 commits intojoomla:4.0-devfrom
astridx:patch-1

Conversation

@astridx
Copy link
Contributor

@astridx astridx commented Mar 20, 2021

Pull Request for Issue # .

Summary of Changes

Added the description for a file that needs to be changed.

Testing Instructions

Code review

Co-authored-by: Brian Teeman <brian@teeman.net>
@astridx
Copy link
Contributor Author

astridx commented Mar 21, 2021

Thank you Richard. I just saw that something else was wrong.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 55244cf

1. Code review: Ok.
2. Real test: Without a phpunit.xml, database tests fail because no database found. After proceeding as adviced in this PR, unit tests worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 55244cf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32758.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 21, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Mar 21, 2021
@wilsonge wilsonge merged commit bb51c1f into joomla:4.0-dev Mar 21, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2021
@wilsonge
Copy link
Contributor

Thanks!

richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 30, 2021
@richard67
Copy link
Member

@astridx @wilsonge Sorry, seems I was sleeping when reviewing this PR. I've found some issues, see #32935 . Please review.

@astridx astridx deleted the patch-1 branch January 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants