[4.0] Articles List Layout vote/ratings fields xml should not be switchers

[infograf768]

Summary of Changes

Vote and ratings fields are list and not switchers. Switchers there are not only displayed wrong but they do not allow to select Use Global settings.

EDIT: This PR also prevents the fields from being displayed when the vote plugin is disabled.

Testing Instructions

Create an articles category list menu item.
Display List Layouts tab.

Look at the Vote and Ratings fields

EDIT: Switch the vote plugin ON and OFF

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

EDIT: See also #31381 (comment)

Documentation Changes Required

[ceford]

Did I do something wrong? My Show Votes in List and Show Ratings in List lists only have Use Global available. No Show or Hide!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[infograf768]

Maybe you have to clear all caches?

[ceford]

This is what I see for a Category List menu item, after new login and clearing cache:

[infograf768]

Have you enabled the vote plugin?

[ceford]

I have enabled the Vote plugin and I now see the drop-down lists. But, Use Global does not have (Show) or (Hide). It seems to me that these two fields should be absent if the plugin is not enabled. Also, it was not obvious to me what the difference was between Show Votes in List and Show Ratings in List. Would it helpful to have the label read Show Number of Votes in List - that does become more obvious when you see the list.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[sandewt]

I have tested this item ✅ successfully on 3502c81

Joomla! 4.0.0-beta6-dev Development [ Mañana ] 27-October-2020 19:54 GMT

See comment

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[sandewt]

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[infograf768]

But, Use Global does not have (Show) or (Hide). It seems to me that these two fields should be absent if the plugin is not enabled.

I guess one has to save Articles Global Options at least once.

[ceford]

Having saved Articles Global Configuration I now see three items in each drop-down list. But if I go back and disable the Vote plugin I see this, with only this one item in the drop-down list:

Is that expected? I am just thinking about how to document this behaviour.

[brianteeman]

If the plugin is disabled then ideally the option should not be displayed at all. Or at least it should be a readonly field with a value of hide. This complex configuration problem has been raised before :(

[sandewt]

This complex configuration problem has been raised before :(

#18354 ?

[infograf768]

@ceford
As the underlying issue is totally independent from this patch, please test it OK so that we set it RTC and merge.

The issue may be treated in another PR if someone works on it.

[infograf768]

In fact, I have a solution for that issue.
If the vote plugin is NOT enabled, the fields would just not display, same as for config.xml

I am now modifying this PR to include the solution.

[infograf768]

Added a new field VotelistField.php and used it for the vote/ratings fields for List Layout
Modifying test instructions
Please test again.

[ceford]

I have tested this item ✅ successfully on 3502c81

All OK if the Vote plugin is enables. I now see that, with the plugin disabled, Use Global (0) or Use Global (1) is the state of the global show flag.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[ceford]

And I can confirm the latest pr does not show the fields if the plugin is disabled.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[infograf768]

Use Global (0) or Use Global (1) is the state of the global show flag.

This will not show anymore when plugin is disabled, whatever the settings in Global when it was enabled or not.

[ceford]

Help screen updated - that will take time to filter through the translation system.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[infograf768]

@sandewt Please test.

[Quy]

Can you also please hide the Voting switch under Articles tab in Global Configuration?

[infograf768]

Can you also please hide the Voting switch under Articles tab in Global Configuration?

Done in ab8b009

[sandewt]

This does not look good with the disabled vote plugin.

See line 288, delete the following code !?

<field
	name="spacer1"
	type="spacer"
	hr="true"
/>

joomla-cms/components/com_content/tmpl/category/default.xml

Line 288 in ab8b009

<field

[infograf768]

@sandewt

See line 288, delete the following code !?

That is not the purpose of this PR.
As we have other instances of spacers in code, I suggest to change all these in another PR if desired.

Example:

Therefore, if this PR works as intended, please mark it such so that we can merge it.

[sandewt]

That is not the purpose of this PR.
As we have other instances of spacers in code, I suggest to change all these in another PR if desired.

Rightly noted.

[sandewt]

I have tested this item ✅ successfully on ab8b009

Joomla! 4.0.0-beta6-dev Development [ Mañana ] 27-October-2020 19:54 GMT

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[infograf768]

RTC thanks for testing.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31381.}

[richard67]

Thanks!