Skip to content

[com_content] - no votes/ratings label if vote plugin disabled#18354

Merged
mbabker merged 2 commits intojoomla:stagingfrom
alikon:patch-69
Oct 19, 2017
Merged

[com_content] - no votes/ratings label if vote plugin disabled#18354
mbabker merged 2 commits intojoomla:stagingfrom
alikon:patch-69

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Oct 16, 2017

Pull Request for Issue #18079 .

Summary of Changes

override the getLabel method
to show the label only if vote plugin is enabled

Testing Instructions

see #18079

Expected result

don't show vote/rating labels if vote plugin is disabled
screenshot from 2017-10-16 20-58-02

Actual result

screenshot from 2017-10-16 20-57-08

Documentation Changes Required

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on be7376e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Oct 16, 2017

I have tested this item ✅ successfully on be7376e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.

@ghost
Copy link

ghost commented Oct 17, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 17, 2017
@sandewt
Copy link
Contributor

sandewt commented Oct 19, 2017

I test this issue successfull, but ...

When I compare the 'Content - Vote' pluging p.e. with the 'Content - Page Navigation' plugin.
And disable the CPN-plugin, the Show Navigation + Switches are staying visible !!!
See Global Configuration > Articles -> Show Navigation.

So I think that the above change is not consistent. Or I'm wrong?

Note: See also my comment in issue #18079.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354.

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Oct 19, 2017
@alikon alikon deleted the patch-69 branch October 20, 2017 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants