[com_content] - no votes/ratings label if vote plugin disabled#18354
Merged
mbabker merged 2 commits intojoomla:stagingfrom Oct 19, 2017
alikon:patch-69
Merged
[com_content] - no votes/ratings label if vote plugin disabled#18354mbabker merged 2 commits intojoomla:stagingfrom alikon:patch-69
mbabker merged 2 commits intojoomla:stagingfrom
alikon:patch-69
Conversation
Contributor
|
I have tested this item ✅ successfully on be7376e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on be7376e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354. |
|
RTC after two successful tests. |
Contributor
|
I test this issue successfull, but ... When I compare the 'Content - Vote' pluging p.e. with the 'Content - Page Navigation' plugin. So I think that the above change is not consistent. Or I'm wrong? Note: See also my comment in issue #18079. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18354. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #18079 .
Summary of Changes
override the getLabel method
to show the label only if vote plugin is enabled
Testing Instructions
see #18079
Expected result
don't show vote/rating labels if vote plugin is disabled

Actual result
Documentation Changes Required