[4.0] Add WebP support to Image library #31048

SharkyKZ · 2020-10-11T13:03:41Z

Summary of Changes

Adds WebP support to image library.

Testing Instructions

Upload a webp image to template directory.
Go to com_templates.
In configuration add webp to Valid Image Formats field.
Go to template files and try to edit the image.

Actual result BEFORE applying this Pull Request

Error:

Attempting to load an image of unsupported type image/webp

Expected result AFTER applying this Pull Request

Image can be opened and edited (but is saved in wrong format).

Documentation Changes Required

IDK.

richard67 · 2020-10-11T14:23:53Z

Expected result AFTER applying this Pull Request

Image can be opened and edited (but is saved in wrong format).

@SharkyKZ Is there something we can do to solve the "is saved in wrong format"? If so, you want to do it with this PR, or want to make a new one, or not want to do it at all?

SharkyKZ · 2020-10-11T14:32:05Z

This is fixed in staging with #30977. Once it reaches 4.0-dev, we'll just need to add a case for WebP.

richard67 · 2020-10-11T14:38:27Z

@SharkyKZ I see. With "format" you meant the size, not the image type, right?

SharkyKZ · 2020-10-11T14:44:08Z

No. All images are saved as JPEGs.

richard67 · 2020-10-11T14:44:42Z

Ah, ok.

richard67 · 2020-10-11T14:45:59Z

At least JPEG and not BMP ;-)

richard67 · 2020-10-11T15:07:01Z

I have tested this item ✅ successfully on 0fabc63

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.}

dgrammatiko · 2020-10-11T18:17:51Z

@SharkyKZ can you check if GD supports AVIF files and if so enable them as well?
Info: https://jakearchibald.com/2020/avif-has-landed/

SharkyKZ · 2020-10-11T18:38:23Z

I don't think it does.

tests/Unit/Libraries/Cms/Image/ImageTest.php

jwaisner · 2020-10-12T00:44:28Z

I have tested this item ✅ successfully on 0fabc63

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.}

jwaisner · 2020-10-12T00:44:40Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.}

tests/Unit/Libraries/Cms/Image/ImageTest.php

Co-authored-by: Quy <[email protected]>

richard67 · 2020-10-12T11:48:05Z

Previous tests are still valid since changes after those were only in code style (indent) and comment.

libraries/src/Image/Image.php

jiweigert · 2020-10-12T13:16:08Z

For the question if GD support AVIF format.

As the underlying libgd don't support it, GD does not either.
There is an open issue at: libgd/libgd#557

Basically, they wait for a plugin that that they can link to and do the work.. or someone who implement avif support.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31048.}

Quy · 2020-10-12T17:23:46Z

Should the installation sql/xml files be updated to include webp for Valid Image Formats?

N6REJ · 2020-10-12T18:22:08Z

how about adding webm @ the same time?

SharkyKZ · 2020-10-12T19:51:37Z

@Quy Not going to do this here. You can make a separate PR. Otherwise I'll wait for #30977 to be merged into 4.0 first.

@N6REJ WebM is not an image format.

piotr-cz · 2020-11-04T10:07:26Z

What are your opinions about backporting this into the 3.x branch?

morsssss · 2021-01-15T23:33:10Z

Hey, I'm excited to see this interest in AVIF from Joomla!

I'm working on implementing libgd/libgd#557 right now...

brianteeman · 2021-01-15T23:53:16Z

@morsssss Thanks for popping in Ben. We have another open issue about AVIF (see #30666) it would be great if you could keep us updated with your progress over there.

morsssss · 2021-01-16T02:05:48Z

Thanks for letting me know! I can do that.

morsssss · 2021-02-22T23:54:31Z

Just letting you know that this PR is almost out of review. I expect it to be merged soon!

joomla#31048 provided the library level support for webp images This PR adds webp to the list of allowed image types for com_templates. It does not have an update sql as that would change user data. This isnt really anything to test here accept codestyle as using webp images in templates was the test for the libray update so we know it works

joomla#31048 added support for webp images however it was not complete. MediaHelper::isImage was not updated to support webp. As a result while webp could be added to media manager as an allowed image format everything worked except for the display of the thumbnail. As this PR fixes that we might as well add webp to the default list of supported image formats. To test 1. either do a fresh install with the prebuilt package OR apply this pr, run npm ci and go to the media manager options. delete all the values in the Legal Extensions (File Types), Legal Image Extensions (File Types) and Legal MIME Types and then save the options. This will reset the value to the new defaults. 2. Try to upload any webp image 3. Try to crop and resize the image 4. Try to rename the image 5. Get a shareable link and make sure it works

SharkyKZ added 2 commits October 11, 2020 15:55

Add WebP support

ba402a1

Add tests

1a48ae9

joomla-cms-bot added PR-4.0-dev Unit/System Tests labels Oct 11, 2020

Update image

0fabc63

Quy reviewed Oct 11, 2020

View reviewed changes

tests/Unit/Libraries/Cms/Image/ImageTest.php Outdated Show resolved Hide resolved

joomla-cms-bot removed the Unit/System Tests label Oct 12, 2020

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 12, 2020

Quy reviewed Oct 12, 2020

View reviewed changes

tests/Unit/Libraries/Cms/Image/ImageTest.php Outdated Show resolved Hide resolved

Reduce indentation

b5347c4

Co-authored-by: Quy <[email protected]>

joomla-cms-bot added the Unit/System Tests label Oct 12, 2020

Update comment

a42f7e6

Co-authored-by: Quy <[email protected]>

HLeithner reviewed Oct 12, 2020

View reviewed changes

libraries/src/Image/Image.php Show resolved Hide resolved

rdeutz merged commit f5c3531 into joomla:4.0-dev Oct 16, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 16, 2020

rdeutz added this to the Joomla 4.0 milestone Oct 16, 2020

brianteeman mentioned this pull request Apr 10, 2021

[4.0] webp support in templates #33087

Merged

brianteeman mentioned this pull request Apr 10, 2021

[4.0] fix webp support #33090

Closed

brianteeman mentioned this pull request May 2, 2021

[4.0] fix webp support #33481

Closed

ChristineWk mentioned this pull request Jul 2, 2021

[4.0] webp support #34690

Merged

Uh oh!

[4.0] Add WebP support to Image library #31048

[4.0] Add WebP support to Image library #31048

Uh oh!

Conversation

SharkyKZ commented Oct 11, 2020

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

richard67 commented Oct 11, 2020

Uh oh!

SharkyKZ commented Oct 11, 2020

Uh oh!

richard67 commented Oct 11, 2020

Uh oh!

SharkyKZ commented Oct 11, 2020

Uh oh!

richard67 commented Oct 11, 2020

Uh oh!

richard67 commented Oct 11, 2020

Uh oh!

richard67 commented Oct 11, 2020

Uh oh!

dgrammatiko commented Oct 11, 2020

Uh oh!

SharkyKZ commented Oct 11, 2020

Uh oh!

Uh oh!

jwaisner commented Oct 12, 2020

Uh oh!

jwaisner commented Oct 12, 2020

Uh oh!

Uh oh!

richard67 commented Oct 12, 2020

Uh oh!

Uh oh!

jiweigert commented Oct 12, 2020

Uh oh!

Quy commented Oct 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

N6REJ commented Oct 12, 2020

Uh oh!

SharkyKZ commented Oct 12, 2020

Uh oh!

piotr-cz commented Nov 4, 2020

Uh oh!

morsssss commented Jan 15, 2021

Uh oh!

brianteeman commented Jan 15, 2021

Uh oh!

morsssss commented Jan 16, 2021

Uh oh!

morsssss commented Feb 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Quy commented Oct 12, 2020 •

edited

Loading