[4.0] webp support #34690
Merged
[4.0] webp support #34690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# added partial support for webp by adding webp to the Legal Image Extensions (File Types) and Legal MIME Types This PR completes the support for webp by adding webp to the Allowed Extensions Also adds thumbnail and icon for webp Makes sure the default values in the xml matches the base.sql This PR does __not__ add the ability to edit a webp image as I tried to do with # as cropperjs is not compatible with firefox for windows. As a result the edit icon is not displayed for webp images
joomla-cms-bot
added
NPM Resource Changed
|
Check 1st Issue-nr. pls. Maybe you meant this: #31048 ? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34690. |
Contributor
Author
|
updated the original post |
Contributor
|
I have tested this item ✅ successfully on acd772a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34690. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on acd772a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34690. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34690. |
Quy
removed
the
NPM Resource Changed
Contributor
|
Thanks! |
joomla-cms-bot
added
NPM Resource Changed
Contributor
Author
|
woohoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34634 added partial support for webp by adding webp to the Legal Image Extensions (File Types) and Legal MIME Types
This PR completes the support for webp by adding webp to the Allowed Extensions
Also adds thumbnail and icon for webp
Makes sure the default values in the xml matches the base.sql
This PR does not add the ability to edit a webp image as I tried to do with #33481 as cropperjs is not compatible with firefox for windows. As a result the edit icon is not displayed for webp images
After the PR