Skip to content

[4.0] Convert jgrid if (icon) to switch (icon) #30482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
N6REJ wants to merge 2 commits into from
Closed

[4.0] Convert jgrid if (icon) to switch (icon) #30482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f24b34e
convert if (icon) to switch (icon)
N6REJ Aug 26, 2020
c2057ce
added break to default
N6REJ Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 65 additions & 69 deletions libraries/src/HTML/Helpers/JGrid.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,41 +90,42 @@ public static function action($i, $task, $prefix = '', $active_title = '', $inac
$html[] = $tip ? ' aria-labelledby="' . $ariaid . '"' : '';
$html[] = '>';

if (strpos($active_class, 'fa-') !== false)
switch ($active_class)
{
$active_class = 'fas ' . $active_class;
}
elseif (strpos($active_class, 'icon-') !== false)
{
$active_class = $active_class;
}
elseif ($active_class === 'publish')
{
$active_class = 'fas fa-check';
}
elseif ($active_class === 'unpublish')
{
$active_class = 'fas fa-times';
}
elseif ($active_class === 'archive')
{
$active_class = 'fas fa-folder';
}
elseif ($active_class === 'checkedout')
{
$active_class = 'fas fa-lock';
}
elseif ($active_class === 'unfeatured')
{
$active_class = 'fas fa-star';
}
elseif ($active_class === 'featured')
{
$active_class = 'fas fa-star featured';
}
else
{
$active_class = 'icon-' . $active_class;
case (strpos($active_class, 'fa-') !== false):
$active_class = 'fas ' . $active_class;
break;

case (strpos($active_class, 'icon-') !== false):
break;

case 'publish':
$active_class = 'fas fa-check';
break;

case 'unpublish':
$active_class = 'fas fa-times';
break;

case 'archive':
$active_class = 'fas fa-folder';
break;

case 'checkedout':
$active_class = 'fas fa-lock';
break;

case 'unfeatured':
$active_class = 'fas fa-star';
break;

case 'featured':
$active_class = 'fas fa-star featured';
break;

default:
$active_class = 'icon-' . $active_class;
break;
}

$html[] = '<span class="' . $active_class . '" aria-hidden="true"></span>';
Expand All @@ -137,52 +138,47 @@ public static function action($i, $task, $prefix = '', $active_title = '', $inac
$html[] = $tip ? ' aria-labelledby="' . $ariaid . '"' : '';
$html[] = '>';

if ($active_class === 'protected')
{
$html[] = '<span class="fas fa-lock" aria-hidden="true"></span>';
}
else
switch ($inactive_class)
{
if (strpos($inactive_class, 'fa-') !== false)
{
case (strpos($inactive_class, 'fa-') !== false):
$inactive_class = 'fas ' . $inactive_class;
}
elseif (strpos($inactive_class, 'icon-') !== false)
{
$inactive_class = $inactive_class;
}
elseif ($inactive_class === 'publish')
{
break;

case (strpos($inactive_class, 'icon-') !== false):
break;

case 'publish':
$inactive_class = 'fas fa-check';
}
elseif ($inactive_class === 'unpublish')
{
break;

case 'unpublish':
$inactive_class = 'fas fa-times';
}
elseif ($inactive_class === 'archive')
{
break;

case 'archive':
$inactive_class = 'fas fa-folder';
}
elseif ($inactive_class === 'checkedout')
{
break;

case 'checkedout':
case 'protected':
$inactive_class = 'fas fa-lock';
}
elseif ($inactive_class === 'unfeatured')
{
break;

case 'unfeatured':
$inactive_class = 'fas fa-star';
}
elseif ($inactive_class === 'featured')
{
break;

case 'featured':
$inactive_class = 'fas fa-star featured';
}
else
{
$inactive_class = 'icon-' . $inactive_class;
}
break;

$html[] = '<span class="' . $inactive_class . '" aria-hidden="true"></span>';
default:
$inactive_class = 'icon-' . $inactive_class;
break;
}

$html[] = '<span class="' . $inactive_class . '" aria-hidden="true"></span>';

$html[] = '</span>';
$html[] = $tip ? '<div role="tooltip" id="' . $ariaid . '">' . $title . '</div>' : '';
}
Expand Down