[4.0] Convert jgrid if (icon) to switch (icon)#30482
Closed
N6REJ wants to merge 2 commits intojoomla:4.0-devfrom
N6REJ:jgrid-to-switch
Closed
[4.0] Convert jgrid if (icon) to switch (icon)#30482N6REJ wants to merge 2 commits intojoomla:4.0-devfrom N6REJ:jgrid-to-switch
N6REJ wants to merge 2 commits intojoomla:4.0-devfrom
N6REJ:jgrid-to-switch
Conversation
Contributor
Author
|
@hans2103 how's this look? |
Contributor
Author
|
@infograf768 can you try your 3rd party app that had icon issues before and let me know if it still works? |
Contributor
|
I have tested this item ✅ successfully on c2057ce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30482. |
Contributor
|
I have tested this item ✅ successfully on c2057ce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30482. |
Member
Looks like this has no impact on com_localise. |
Contributor
Author
Contributor
Author
|
closing since we've merged it now #30470 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
converts multiple if statements into switch statements.
Testing Instructions
inspect administrator/index.php?option=com_content&view=articles
verify icons display properly using fas fa- in class names.
apply pr.
verify icons still use fas fa- in class names and display the same icons.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none