[#32958] Show fieldset descriptions in modules, menus, plugins parameters#3048
Merged
infograf768 merged 1 commit intojoomla:stagingfrom May 30, 2014
Merged
Conversation
Contributor
|
Tested. Works as expected |
infograf768
added a commit
that referenced
this pull request
May 30, 2014
[#32958] Show fieldset descriptions in modules, menus, plugins parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as PR #2686, but against staging.
Issue
Fieldset descriptions don't show up. This is because the code is currently in the layout
joomla.edit.fieldsetbut we don't have this description information there. It looks for a property of the (assumed) object$fieldSetwhile in fact$fieldSetis an array of fields.This is the case everywhere except for the component parameters itself. So in modules, plugins, menus and templates parameters and maybe also other places.
Solution
Moving the code to the
joomla.edit.paramslayout where this information (the object) is present.Testing Instructions
Try to add a description to a fieldset. For example in modules/mod_articles_news/mod_articles_news.xml change
to
Currently, the description isn't shown, after the patch is applied it will show.
Known Limitations
This patch only covers "custom" fieldsets. The basic ones (like
basic,description,request) are threated differently in the code and thus need to be taken care seperately.Tracker
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32958