[4.0] Implementing display of fieldset descriptions for fieldset children#30450
Conversation
|
I have tested this item ✅ successfully on 151b0ac This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30450. |
layouts/joomla/edit/params.php
Outdated
| echo '<legend>' . $label . '</legend>'; | ||
|
|
||
| // Include the description when available | ||
| if (isset($fieldSet->description) && trim($fieldSet->description)) |
There was a problem hiding this comment.
| if (isset($fieldSet->description) && trim($fieldSet->description)) | |
| if (!empty($fieldSet->description)) |
|
I haven't changed the code itself in that old PR, I just moved it to a different place. So I wasn't thinking about why the trim is there. There would be a small difference between the code, that is when the description holds only a whitespace. The first line wouldn't show it (because trim removes the space), the second line would show it. Personally, I would go with |
|
@Quy @obuisard @richard67 |
|
I have tested this item ✅ successfully on 83c9d5b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30450. |
1 similar comment
|
I have tested this item ✅ successfully on 83c9d5b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30450. |
|
Back to RTC Appveyor failure is unrelated. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30450. |
|
Took off an extraneous new line at the end of _alerts.scss to force rebuild to solve appveyor failure to run. |
Pull Request for Issues #30433 & #30431
Summary of Changes
Added the possibility to display fieldsets description for children (and parent when there are children)
Testing Instructions
Structure of a xml with children fieldsets
For example, replace the file
modules/mod_articles_category/mod_articles_category.xmlwhere I have made such a structure.with this one (unzip first)
mod_articles_category.xml.zip
Test, then patch and run NPM as we have a small scss change.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
@obuisard
Please test and add your test result on https://issues.joomla.org/tracker/joomla-cms/30450