Skip to content

[4.0] Update editor versions in manifest files#30340

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/manifest/editors
Aug 11, 2020
Merged

[4.0] Update editor versions in manifest files#30340
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/manifest/editors

Conversation

@SharkyKZ
Copy link
Contributor

Summary of Changes

This was missed in #30334.

Testing Instructions

Code review.

Documentation Changes Required

No.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 9abaf78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 9abaf78


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30340.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 11, 2020
@dgrammatiko
Copy link
Contributor

FWIW the build tools should do this automatically, eg someone has to do the changes in the package.json (eg npm audit --fix) and then run npm install again. The whole idea was that the 3rd party dependencies should be a fairly easy maintenance task

@wilsonge wilsonge merged commit 7409414 into joomla:4.0-dev Aug 11, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 11, 2020
@wilsonge
Copy link
Contributor

Yeah dunno whether the files weren't added or something else. the build tools do still work doing that though

@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 11, 2020
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 13, 2020
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms:
  Add closing quote (joomla#30353)
  [4.0] Make sure the renderer does not manipulate the inline CSS and JS (joomla#28719)
  [4.0] Atum and Cassiopea Change alerts styling - space saving + (joomla#30294)
  Update editor versions (joomla#30340)
  [4.0][mod_menu] Add space for 'menu class' (joomla#30341)
  Optimize code for aria-current (joomla#30328)
  [4.0] Composer and npm updates 10 Aug (joomla#30334)
  [4.0] fix js code style (joomla#30335)
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments