[4.0] Composer and npm updates 10 Aug#30334
Conversation
joomla-cms-bot
added
Composer Dependency Changed
NPM Resource Changed
|
I've restarted Drone 2 times now, and it always fails at the "javascript-cs" step, where it hasn't failed before, see https://ci.joomla.org/joomla/joomla-cms/34613/1/25. No idea if that is caused by this PR here. Update: Maybe eslint comes with different default rules now? |
|
@richard67 they are valid errors but unrelated to this pr |
|
@brianteeman But why don't they fail on the current 4.0-dev branch? |
|
No idea as the drone configuration is a mystery to me |
Then we are at least two. |
|
Just run |
That was what I thought, too. @brianteeman Could you do as suggested by Dimitris and add the fixed js to this PR? Thanks in advance. |
|
i am doing that now
…On Mon, 10 Aug 2020 at 12:53, dGrammatiko ***@***.***> wrote:
Just run npx eslint --fix "**/*.js", the errors are really minor here
(multiple empty line, probably a changed rule in the eslint base config
coming from airbnb-base)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30334 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ4P4MGVUK2QD72EYYBDQLR77NUTANCNFSM4PZ3M5OQ>
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ <http://brian.teeman.net/>
|
|
I guess your PR replaces #30248 , right? |
|
Solves #30319 . |
|
PR with the cs fixes is #30335 . |
|
@brianteeman I've merged the cs corrections by review. Could you update the branch of this PR to latest 4.0-dev so we can see if Drone passes now here? Thanks in advance. |
As the title says
|
Analysis4x/rips is complaining. I guess it's a false alarm, but it's continuously doing that, I've tried a few Drone job restarts. @SniperSister or @zero-24 Could you check that? |
|
Finally after having restarted Drone some 150 or so times, all tests passed. |
|
Sorry seems i missed to send the update here. We had an false positive and i rebooted drone. Great that it now passes. |
|
I'll call the tests good enough for the dependency update whilst we're still in Beta |
|
Thanks stranger ;) |
…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: Add closing quote (joomla#30353) [4.0] Make sure the renderer does not manipulate the inline CSS and JS (joomla#28719) [4.0] Atum and Cassiopea Change alerts styling - space saving + (joomla#30294) Update editor versions (joomla#30340) [4.0][mod_menu] Add space for 'menu class' (joomla#30341) Optimize code for aria-current (joomla#30328) [4.0] Composer and npm updates 10 Aug (joomla#30334) [4.0] fix js code style (joomla#30335)
6 participants
As the title says